Moves WorkspaceController to ash/common

Moves WorkspaceController to ash/common

I move creation to RootWindowControllerCommon, but I think
RootWindowControllerCommon should go away. I'm going to do that next,
which will result in some additional cleanup.

BUG=624173
TEST=covered by tests
R=msw@chromium.org

Committed: https://crrev.com/f71e6c9fa86982eed0647462082293803e39c9e6
Cr-Commit-Position: refs/heads/master@{#415374}

[sky, 2016-08-30 17:25:22]

https://codereview.chromium.org/2292183003/diff/1/ash/common/wm/workspace_con...
File ash/common/wm/workspace_controller.h (right):

https://codereview.chromium.org/2292183003/diff/1/ash/common/wm/workspace_con...
ash/common/wm/workspace_controller.h:46: void OnWindowDestroying(WmWindow*
window) override;
The mus side necessitates this (642182).

[sky, 2016-08-30 17:25:26]

The CQ bit was checked by sky@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 17:25:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 17:28:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 17:28:14]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[msw, 2016-08-30 17:46:20]

lgtm

https://codereview.chromium.org/2292183003/diff/1/ash/common/wm/workspace_con...
File ash/common/wm/workspace_controller.h (right):

https://codereview.chromium.org/2292183003/diff/1/ash/common/wm/workspace_con...
ash/common/wm/workspace_controller.h:46: void OnWindowDestroying(WmWindow*
window) override;
On 2016/08/30 17:25:22, sky wrote:
> The mus side necessitates this (642182).

Acknowledged.

https://codereview.chromium.org/2292183003/diff/1/ash/root_window_controller.cc
File ash/root_window_controller.cc (left):

https://codereview.chromium.org/2292183003/diff/1/ash/root_window_controller....
ash/root_window_controller.cc:376: workspace_controller_.reset();
nice (called in CloseChildWindows)

https://codereview.chromium.org/2292183003/diff/1/ash/root_window_controller.h
File ash/root_window_controller.h (right):

https://codereview.chromium.org/2292183003/diff/1/ash/root_window_controller....
ash/root_window_controller.h:114: WorkspaceController* workspace_controller();
nit: GetWorkspaceController? (ok as-is temporarily)

https://codereview.chromium.org/2292183003/diff/20001/ash/common/wm/workspace...
File ash/common/wm/workspace_controller.h (right):

https://codereview.chromium.org/2292183003/diff/20001/ash/common/wm/workspace...
ash/common/wm/workspace_controller.h:24: class ASH_EXPORT WorkspaceController :
public WmWindowObserver {
nit: it'd be nice if you could cleanup
WmRootWindowController::SetMaximizeBackdropDelegate (perhaps in the next CL)
https://cs.chromium.org/chromium/src/ash/common/wm_root_window_controller.h?r...

[sky, 2016-08-30 17:55:10]

https://codereview.chromium.org/2292183003/diff/1/ash/root_window_controller.h
File ash/root_window_controller.h (right):

https://codereview.chromium.org/2292183003/diff/1/ash/root_window_controller....
ash/root_window_controller.h:114: WorkspaceController* workspace_controller();
On 2016/08/30 17:46:20, msw wrote:
> nit: GetWorkspaceController? (ok as-is temporarily)

The style guide says this about function names "Functions that are very cheap to
call may instead follow the style for variable names". As this is cheap,
unix_hacker_style is still fine.

https://codereview.chromium.org/2292183003/diff/20001/ash/common/wm/workspace...
File ash/common/wm/workspace_controller.h (right):

https://codereview.chromium.org/2292183003/diff/20001/ash/common/wm/workspace...
ash/common/wm/workspace_controller.h:24: class ASH_EXPORT WorkspaceController :
public WmWindowObserver {
On 2016/08/30 17:46:20, msw wrote:
> nit: it'd be nice if you could cleanup
> WmRootWindowController::SetMaximizeBackdropDelegate (perhaps in the next CL)
>
https://cs.chromium.org/chromium/src/ash/common/wm_root_window_controller.h?r...

Yes, I was planning on doing that once I merge RootWindowControllerCommon into
WmRootWindowController.

[sky, 2016-08-30 17:55:56]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2016-08-30 17:56:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 18:49:49]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-30 18:51:52]

Description was changed from

==========
Moves WorkspaceController to ash/common

I move creation to RootWindowControllerCommon, but I think
RootWindowControllerCommon should go away. I'm going to do that next,
which will result in some additional cleanup.

BUG=624173
TEST=covered by tests
R=msw@chromium.org
==========

to

==========
Moves WorkspaceController to ash/common

I move creation to RootWindowControllerCommon, but I think
RootWindowControllerCommon should go away. I'm going to do that next,
which will result in some additional cleanup.

BUG=624173
TEST=covered by tests
R=msw@chromium.org

Committed: https://crrev.com/f71e6c9fa86982eed0647462082293803e39c9e6
Cr-Commit-Position: refs/heads/master@{#415374}
==========

[commit-bot: I haz the power, 2016-08-30 18:51:53]

Patchset 2 (id:??) landed as
https://crrev.com/f71e6c9fa86982eed0647462082293803e39c9e6
Cr-Commit-Position: refs/heads/master@{#415374}