Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/inspector/InjectedScript.h

Issue 2292053003: [inspector] Build inspector under v8_enable_inspector build flag. (Closed)
Patch Set: owners Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build_overrides/v8.gni ('K') | « src/inspector/BUILD.gn ('k') | src/inspector/InjectedScript.cpp » ('j') | src/v8.gyp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/inspector/InjectedScript.h
diff --git a/src/inspector/InjectedScript.h b/src/inspector/InjectedScript.h
index bfda761b31926efd639db8cc22fb075bc63b51d5..2c5c8835f69fb6df8c8d1f428b9dcca5b9b4a23e 100644
--- a/src/inspector/InjectedScript.h
+++ b/src/inspector/InjectedScript.h
@@ -39,7 +39,7 @@
#include "src/inspector/protocol/Forward.h"
#include "src/inspector/protocol/Runtime.h"
-#include <v8.h>
+#include "include/v8.h"
namespace v8_inspector {
@@ -118,7 +118,7 @@ class InjectedScript final {
protected:
Scope(ErrorString*, V8InspectorImpl*, int contextGroupId);
- ~Scope();
+ virtual ~Scope();
virtual void findInjectedScript(V8InspectorSessionImpl*) = 0;
ErrorString* m_errorString;
« build_overrides/v8.gni ('K') | « src/inspector/BUILD.gn ('k') | src/inspector/InjectedScript.cpp » ('j') | src/v8.gyp » ('J')

Powered by Google App Engine
This is Rietveld 408576698