Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 2292023002: Audit the use of updateStyleAndLayoutIgnorePendingStylesheets in TextIterator::rangeLength (Closed)

Created:
4 years, 3 months ago by Xiaocheng
Modified:
4 years, 3 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Audit the use of updateStyleAndLayoutIgnorePendingStylesheets in TextIterator::rangeLength BUG=590369 Committed: https://crrev.com/d458f0472a278384106520e6312986f1fd138927 Cr-Commit-Position: refs/heads/master@{#416159}

Patch Set 1 #

Patch Set 2 : 201609011431 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M third_party/WebKit/Source/core/editing/iterators/TextIterator.cpp View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
Xiaocheng
PTAL.
4 years, 3 months ago (2016-09-02 01:41:58 UTC) #11
yosin_UTC9
lgtm
4 years, 3 months ago (2016-09-02 01:43:11 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2292023002/20001
4 years, 3 months ago (2016-09-02 01:43:21 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-02 01:47:31 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 01:51:18 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d458f0472a278384106520e6312986f1fd138927
Cr-Commit-Position: refs/heads/master@{#416159}

Powered by Google App Engine
This is Rietveld 408576698