Notify LayoutImage that intrinsic dimensions changed when sizes changes

Notify LayoutImage that intrinsic dimensions changed when sizes changes

When the sizes attribute changes, that has the potential of modifying the
image's intrinsic dimensions. However, the LayoutImage object was not
notified of that explicitly. While the intrinsic dimensions were changed
when a new resource was downloaded as a result of the sizes attribute
change, that wasn't the case when such the resource was not changed.

This CL fixes that, by explicitly notifying the LayoutImage of the change.

BUG=639845
Committed: https://crrev.com/caccabc07cfb56d982d3933a5b938f190ee34ec4
Cr-Commit-Position: refs/heads/master@{#415369}

[Yoav Weiss, 2016-08-30 09:20:21]

The CQ bit was checked by yoav@yoav.ws to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 09:20:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yoav Weiss, 2016-08-30 09:22:45]

yoav@yoav.ws changed reviewers:
+ mkwst@chromium.org

[Yoav Weiss, 2016-08-30 09:22:46]

Hey Mike,

Care to take a look at this patch? The change is not huge, and I think you were
the last person reviewing my patches in that area.

If you think someone else should be reviewing, feel free to redirect :D

[commit-bot: I haz the power, 2016-08-30 11:09:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 11:09:54]

Dry run: This issue passed the CQ dry run.

[Stephen Chennney, 2016-08-30 13:32:24]

schenney@chromium.org changed reviewers:
+ schenney@chromium.org

[Stephen Chennney, 2016-08-30 13:32:24]

Thanks for the quick fix. Code looks fine, but I have a question about the test.

https://codereview.chromium.org/2292013002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/dom/HTMLImageElement/sizes-changed-intrinsic-size-update.html
(right):

https://codereview.chromium.org/2292013002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/dom/HTMLImageElement/sizes-changed-intrinsic-size-update.html:15:
bla.onload = t.step_func(function() {
Should it be the case here that bla.width == 1600? There's nothing in the test
that confirms that the bla.sizes = 1600px has any effect. We could just be
seeing that the size didn't change at all.

[Yoav Weiss, 2016-08-30 15:02:12]

https://codereview.chromium.org/2292013002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/dom/HTMLImageElement/sizes-changed-intrinsic-size-update.html
(right):

https://codereview.chromium.org/2292013002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/dom/HTMLImageElement/sizes-changed-intrinsic-size-update.html:15:
bla.onload = t.step_func(function() {
On 2016/08/30 13:32:24, Stephen Chennney wrote:
> Should it be the case here that bla.width == 1600? There's nothing in the test
> that confirms that the bla.sizes = 1600px has any effect. We could just be
> seeing that the size didn't change at all.

Good point. Added a test for that.

[Yoav Weiss, 2016-08-30 15:02:12]

The CQ bit was checked by yoav@yoav.ws to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 15:02:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Stephen Chennney, 2016-08-30 15:18:44]

On 2016/08/30 15:02:12, Yoav Weiss wrote:
>
https://codereview.chromium.org/2292013002/diff/1/third_party/WebKit/LayoutTe...
> File
>
third_party/WebKit/LayoutTests/fast/dom/HTMLImageElement/sizes-changed-intrinsic-size-update.html
> (right):
> 
>
https://codereview.chromium.org/2292013002/diff/1/third_party/WebKit/LayoutTe...
>
third_party/WebKit/LayoutTests/fast/dom/HTMLImageElement/sizes-changed-intrinsic-size-update.html:15:
> bla.onload = t.step_func(function() {
> On 2016/08/30 13:32:24, Stephen Chennney wrote:
> > Should it be the case here that bla.width == 1600? There's nothing in the
test
> > that confirms that the bla.sizes = 1600px has any effect. We could just be
> > seeing that the size didn't change at all.
> 
> Good point. Added a test for that.

Thanks. LGTM.

[commit-bot: I haz the power, 2016-08-30 16:38:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 16:38:22]

Dry run: This issue passed the CQ dry run.

[Yoav Weiss, 2016-08-30 18:38:01]

The CQ bit was checked by yoav@yoav.ws

[commit-bot: I haz the power, 2016-08-30 18:38:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 18:44:38]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-30 18:46:29]

Description was changed from

==========
Notify LayoutImage that intrinsic dimensions changed when sizes changes

When the sizes attribute changes, that has the potential of modifying the
image's intrinsic dimensions. However, the LayoutImage object was not
notified of that explicitly. While the intrinsic dimensions were changed
when a new resource was downloaded as a result of the sizes attribute
change, that wasn't the case when such the resource was not changed.

This CL fixes that, by explicitly notifying the LayoutImage of the change.

BUG=639845
==========

to

==========
Notify LayoutImage that intrinsic dimensions changed when sizes changes

When the sizes attribute changes, that has the potential of modifying the
image's intrinsic dimensions. However, the LayoutImage object was not
notified of that explicitly. While the intrinsic dimensions were changed
when a new resource was downloaded as a result of the sizes attribute
change, that wasn't the case when such the resource was not changed.

This CL fixes that, by explicitly notifying the LayoutImage of the change.

BUG=639845

Committed: https://crrev.com/caccabc07cfb56d982d3933a5b938f190ee34ec4
Cr-Commit-Position: refs/heads/master@{#415369}
==========

[commit-bot: I haz the power, 2016-08-30 18:46:30]

Patchset 2 (id:??) landed as
https://crrev.com/caccabc07cfb56d982d3933a5b938f190ee34ec4
Cr-Commit-Position: refs/heads/master@{#415369}