third_party/WebKit/LayoutTests/fast/dom/HTMLImageElement/sizes-changed-intrinsic-size-update.html - Issue 2292013002: Notify LayoutImage that intrinsic dimensions changed when sizes changes

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/dom/HTMLImageElement/sizes-changed-intrinsic-size-update.html

Issue 2292013002: Notify LayoutImage that intrinsic dimensions changed when sizes changes (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../../resources/testharness.js"></script>

	3 <script src="../../../resources/testharnessreport.js"></script>

	4 <body>

	5 <img id="bla"

	6 srcset="resources/black.png 100w,

	7 resources/image-set-4x.png 1600w"

	8 sizes="100px"

	9 >

	10 <script>

	11 var t = async_test('Make sure that a sizes change also changes the intrinsic dimensions');

	12 window.onload = t.step_func(function() {

	13

	14 var bla = document.getElementById("bla");

	15 bla.onload = t.step_func(function() {
	Stephen Chennney 2016/08/30 13:32:24 Should it be the case here that bla.width == 1600? Should it be the case here that bla.width == 1600? There's nothing in the test that confirms that the bla.sizes = 1600px has any effect. We could just be seeing that the size didn't change at all. Yoav Weiss 2016/08/30 15:02:12 Good point. Added a test for that. Show quoted text On 2016/08/30 13:32:24, Stephen Chennney wrote: > Should it be the case here that bla.width == 1600? There's nothing in the test > that confirms that the bla.sizes = 1600px has any effect. We could just be > seeing that the size didn't change at all. Good point. Added a test for that.
	16 bla.onload = function(){};

	17 bla.sizes = "100px";

	18 assert_equals(bla.width, 100);

	19 t.done();

	20 });

	21 bla.sizes = "1600px";

	22 });

	23 </script>

	24 </body>

	25 </html>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLImageElement.cpp » ('j') | no next file with comments »