Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Unified Diff: components/ntp_snippets/content_suggestions_provider.h

Issue 2292003002: Move OnURLsDeleted from NTPSnippetsService to ContentSuggestionsService (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/ntp_snippets/content_suggestions_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/ntp_snippets/content_suggestions_provider.h
diff --git a/components/ntp_snippets/content_suggestions_provider.h b/components/ntp_snippets/content_suggestions_provider.h
index 8d292523a75b6d6c07a27b9f549105d9798ca172..ef160b9dee0a0954ba1b8bfe6bf557660a2a54fe 100644
--- a/components/ntp_snippets/content_suggestions_provider.h
+++ b/components/ntp_snippets/content_suggestions_provider.h
@@ -102,6 +102,14 @@ class ContentSuggestionsProvider {
virtual void FetchSuggestionImage(const std::string& suggestion_id,
const ImageFetchedCallback& callback) = 0;
+ // Removes given list of URLs and associated data (depends on a provider).
Marc Treib 2016/08/30 09:42:32 Removes from where? s/a provider/the provider/
vitaliii 2016/09/02 12:38:30 Done.
+ // Providers should immediately clear any history-related data associated with
+ // |deleted_rows| or all data if |all_history| is true. If |expired| is true,
+ // then the deletion is due to expiration and providers may ignore it.
Marc Treib 2016/08/30 09:42:32 Would any provider ever care about expired URLs? I
vitaliii 2016/09/02 12:38:30 Done.
+ virtual void RemoveURLsFromHistory(bool all_history,
+ bool expired,
+ const history::URLRows& deleted_rows) = 0;
vitaliii 2016/08/30 08:57:31 Marc, would you mind checking the interface? I ign
Marc Treib 2016/08/30 09:42:32 Yup, this sounds reasonable.
Marc Treib 2016/08/30 09:42:32 It might be nice not to use history:: types here,
vitaliii 2016/09/02 12:38:30 Done.
+
// Removes history from a given time range. The data removed depends on a
// provider. Note that the data outside the time range may be deleted, for
// example suggestions, which are based on the time range. Providers should
« no previous file with comments | « no previous file | components/ntp_snippets/content_suggestions_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698