Move OnURLsDeleted from NTPSnippetsService to ContentSuggestionsService

components/ntp_snippets/content_suggestions_provider.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_NTP_SNIPPETS_CONTENT_SUGGESTIONS_PROVIDER_H_
 #define COMPONENTS_NTP_SNIPPETS_CONTENT_SUGGESTIONS_PROVIDER_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 84 matching lines @@
   virtual void DismissSuggestion(const std::string& suggestion_id) = 0;
 
   // Fetches the image for the suggestion with the given ID and returns it
   // through the callback. This fetch may occur locally or from the internet.
   // If that suggestion doesn't exist, doesn't have an image or if the fetch
   // fails, the callback gets a null image. The callback will not be called
   // synchronously.
   virtual void FetchSuggestionImage(const std::string& suggestion_id,
                                     const ImageFetchedCallback& callback) = 0;
 
+  // Removes given list of URLs and associated data (depends on a provider).

[Marc Treib, 2016/08/30 09:42:32]

Removes from where?
s/a provider/the provider/

[vitaliii, 2016/09/02 12:38:30]

Done.

+  // Providers should immediately clear any history-related data associated with
+  // |deleted_rows| or all data if |all_history| is true. If |expired| is true,
+  // then the deletion is due to expiration and providers may ignore it.

[Marc Treib, 2016/08/30 09:42:32]

Would any provider ever care about expired URLs? If not, let's just remove the
parameter, and have the service not forward those events.

[vitaliii, 2016/09/02 12:38:30]

Done.

+  virtual void RemoveURLsFromHistory(bool all_history,
+                                     bool expired,
+                                     const history::URLRows& deleted_rows) = 0;

[vitaliii, 2016/08/30 08:57:31]

Marc, would you mind checking the interface?
I ignore |std::set<GURL>& favicon_urls|, because
1) we do not need them;
2) set of URLs does not look useful.

[Marc Treib, 2016/08/30 09:42:32]

Yup, this sounds reasonable.

[Marc Treib, 2016/08/30 09:42:32]

It might be nice not to use history:: types here, otherwise every provider has
to include some history header. Do we need anything other than the actual URLs?

[vitaliii, 2016/09/02 12:38:30]

Done.

+
   // Removes history from a given time range. The data removed depends on a
   // provider. Note that the data outside the time range may be deleted, for
   // example suggestions, which are based on the time range. Providers should
   // immediately clear any specified time range history-related data, such as
   // (possibly dismissed) suggestions for NTPSnippetsService or in case of
   // BookmarkSuggestionsProvider last visit dates.
   virtual void ClearHistory(base::Time begin, base::Time end) = 0;
 
   // Clears all caches for the given category, so that the next fetch starts
   // from scratch.
@@ skipping 36 matching lines @@
   CategoryFactory* category_factory() const { return category_factory_; }
 
  private:
   Observer* observer_;
   CategoryFactory* category_factory_;
 };
 
 }  // namespace ntp_snippets
 
 #endif  // COMPONENTS_NTP_SNIPPETS_CONTENT_SUGGESTIONS_PROVIDER_H_