android_webview/native/permission/media_access_permission_request_unittest.cc - Issue 2291893002: Let Contraints Controll Mute/Unmute Audio Local Playback For Desktop Sharing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/native/permission/media_access_permission_request_unittest.cc

Issue 2291893002: Let Contraints Controll Mute/Unmute Audio Local Playback For Desktop Sharing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Resolve Browser Test Issuex Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: android_webview/native/permission/media_access_permission_request_unittest.cc

diff --git a/android_webview/native/permission/media_access_permission_request_unittest.cc b/android_webview/native/permission/media_access_permission_request_unittest.cc

index eae252bb7336e492ec756a2108999bbd4e4ea9e4..2a7f9c5de983696f9c4ed7667450a9410ae75b8a 100644

--- a/android_webview/native/permission/media_access_permission_request_unittest.cc

+++ b/android_webview/native/permission/media_access_permission_request_unittest.cc

@@ -53,7 +53,7 @@ class MediaAccessPermissionRequestTest : public testing::Test {

content::MediaStreamRequest request(

0, 0, 0, origin, false, content::MEDIA_GENERATE_STREAM, audio_id,

video_id, content::MEDIA_DEVICE_AUDIO_CAPTURE,

- content::MEDIA_DEVICE_VIDEO_CAPTURE);

+ content::MEDIA_DEVICE_VIDEO_CAPTURE, false);

boliu 2016/10/05 17:31:25 nit: maybe add an inline comment to make this a bi

qiangchen 2016/10/05 18:13:57 Done.

std::unique_ptr<TestMediaAccessPermissionRequest> permission_request;

permission_request.reset(new TestMediaAccessPermissionRequest(

« no previous file with comments | « no previous file | chrome/browser/media/webrtc/desktop_capture_access_handler.cc » ('j') | no next file with comments »