Let Contraints Controll Mute/Unmute Audio Local Playback For Desktop Sharing

android_webview/native/permission/media_access_permission_request_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "android_webview/native/permission/media_access_permission_request.h"
 #include "base/bind.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace android_webview {
 
@@ skipping 35 matching lines @@
         content::MediaStreamDevice(content::MEDIA_DEVICE_VIDEO_CAPTURE,
                                    first_video_device_id_, "v2"));
     video_devices.push_back(
         content::MediaStreamDevice(content::MEDIA_DEVICE_VIDEO_CAPTURE,
                                    video_device_id_, "v1"));
 
     GURL origin("https://www.google.com");
     content::MediaStreamRequest request(
         0, 0, 0, origin, false, content::MEDIA_GENERATE_STREAM, audio_id,
         video_id, content::MEDIA_DEVICE_AUDIO_CAPTURE,
-        content::MEDIA_DEVICE_VIDEO_CAPTURE);
+        content::MEDIA_DEVICE_VIDEO_CAPTURE, false);

[boliu, 2016/10/05 17:31:25]

nit: maybe add an inline comment to make this a bit easier to read

false /* disable_local_echo */

[qiangchen, 2016/10/05 18:13:57]

Done.

 
     std::unique_ptr<TestMediaAccessPermissionRequest> permission_request;
     permission_request.reset(new TestMediaAccessPermissionRequest(
         request,
         base::Bind(&MediaAccessPermissionRequestTest::Callback,
                    base::Unretained(this)),
         audio_devices, video_devices));
     return permission_request;
   }
 
@@ skipping 62 matching lines @@
 
 TEST_F(MediaAccessPermissionRequestTest, TestDenyPermissionRequest) {
   std::unique_ptr<TestMediaAccessPermissionRequest> request =
       CreateRequest(std::string(), std::string());
   request->NotifyRequestResult(false);
   EXPECT_TRUE(devices_.empty());
   EXPECT_EQ(content::MEDIA_DEVICE_PERMISSION_DENIED, result_);
 }
 
 }  // namespace android_webview