Ensure clean layout before calling TextIterator::rangeLength in editing code

Ensure clean layout before calling TextIterator::rangeLength in editing code

This patch is a preparation for removing the call site of
Document::updateStyleAndLayoutIgnorePendingStylesheets from
TextIterator::rangeLength.

BUG=590369
Committed: https://crrev.com/0e35e759f3b4b41bf55b04155fa3cdd028308a1e
Cr-Commit-Position: refs/heads/master@{#415260}

[Xiaocheng, 2016-08-30 06:51:10]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 06:51:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-08-30 07:17:58]

xiaochengh@chromium.org changed reviewers:
+ yosin@chromium.org

[Xiaocheng, 2016-08-30 07:17:59]

PTAL.

[yosin_UTC9, 2016-08-30 07:40:24]

lgtm

https://codereview.chromium.org/2291883003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/EditingUtilities.cpp (right):

https://codereview.chromium.org/2291883003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/EditingUtilities.cpp:1707:
document.updateStyleAndLayoutIgnorePendingStylesheets();
I hope following patch will hoist this updateLayout to call sites of
indexForVisiblePosition()

https://codereview.chromium.org/2291883003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/PlainTextRange.cpp (right):

https://codereview.chromium.org/2291883003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/PlainTextRange.cpp:181:
scope.document().updateStyleAndLayoutIgnorePendingStylesheets();
I hope following patch will hoist this updateLayout to call sites of
PlainTextRange::create

[Xiaocheng, 2016-08-30 07:42:52]

Thanks.

https://codereview.chromium.org/2291883003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/EditingUtilities.cpp (right):

https://codereview.chromium.org/2291883003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/EditingUtilities.cpp:1707:
document.updateStyleAndLayoutIgnorePendingStylesheets();
On 2016/08/30 at 07:40:24, Yosi_UTC9 wrote:
> I hope following patch will hoist this updateLayout to call sites of
indexForVisiblePosition()

Yeah, there will be such a patch.

https://codereview.chromium.org/2291883003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/PlainTextRange.cpp (right):

https://codereview.chromium.org/2291883003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/PlainTextRange.cpp:181:
scope.document().updateStyleAndLayoutIgnorePendingStylesheets();
On 2016/08/30 at 07:40:24, Yosi_UTC9 wrote:
> I hope following patch will hoist this updateLayout to call sites of
PlainTextRange::create

Yeah, there will be such a patch.

[commit-bot: I haz the power, 2016-08-30 07:55:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 07:55:39]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Xiaocheng, 2016-08-30 08:06:23]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 08:06:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 09:46:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 09:46:22]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2016-08-30 09:47:36]

The CQ bit was checked by xiaochengh@chromium.org

[commit-bot: I haz the power, 2016-08-30 09:47:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 09:51:58]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-30 09:54:45]

Description was changed from

==========
Ensure clean layout before calling TextIterator::rangeLength in editing code

This patch is a preparation for removing the call site of
Document::updateStyleAndLayoutIgnorePendingStylesheets from
TextIterator::rangeLength.

BUG=590369
==========

to

==========
Ensure clean layout before calling TextIterator::rangeLength in editing code

This patch is a preparation for removing the call site of
Document::updateStyleAndLayoutIgnorePendingStylesheets from
TextIterator::rangeLength.

BUG=590369

Committed: https://crrev.com/0e35e759f3b4b41bf55b04155fa3cdd028308a1e
Cr-Commit-Position: refs/heads/master@{#415260}
==========

[commit-bot: I haz the power, 2016-08-30 09:54:46]

Patchset 1 (id:??) landed as
https://crrev.com/0e35e759f3b4b41bf55b04155fa3cdd028308a1e
Cr-Commit-Position: refs/heads/master@{#415260}