Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: third_party/WebKit/Source/core/editing/PlainTextRange.cpp

Issue 2291883003: Ensure clean layout before calling TextIterator::rangeLength in editing code (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/PlainTextRange.cpp
diff --git a/third_party/WebKit/Source/core/editing/PlainTextRange.cpp b/third_party/WebKit/Source/core/editing/PlainTextRange.cpp
index adf72eb1d972fe8bc7da02fbca99f43469217288..822ae4f10fe3db22514452057a8f152edd9c54f1 100644
--- a/third_party/WebKit/Source/core/editing/PlainTextRange.cpp
+++ b/third_party/WebKit/Source/core/editing/PlainTextRange.cpp
@@ -176,6 +176,10 @@ PlainTextRange PlainTextRange::create(const ContainerNode& scope, const Ephemera
if (endContainer != scope && !endContainer->isDescendantOf(&scope))
return PlainTextRange();
+ // TODO(xiaochengh): The use of updateStyleAndLayoutIgnorePendingStylesheets
+ // needs to be audited. See http://crbug.com/590369 for more details.
+ scope.document().updateStyleAndLayoutIgnorePendingStylesheets();
yosin_UTC9 2016/08/30 07:40:24 I hope following patch will hoist this updateLayou
Xiaocheng 2016/08/30 07:42:52 Yeah, there will be such a patch.
+
size_t start = TextIterator::rangeLength(Position(&const_cast<ContainerNode&>(scope), 0), range.startPosition());
size_t end = TextIterator::rangeLength(Position(&const_cast<ContainerNode&>(scope), 0), range.endPosition());

Powered by Google App Engine
This is Rietveld 408576698