Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Issue 2291833002: Revert "Replace wrapper methods in CPDF_Path with -> operator." (Closed)

Created:
4 years, 3 months ago by Tom Sepez
Modified:
4 years, 3 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Revert "Replace wrapper methods in CPDF_Path with -> operator." This reverts commit d09a09751f724ecdb1a0bc307447a3d0c212ebff. TBR=dsinclair@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/596014357f7cd9ee3245ba8ed52cbc5761151727

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -91 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_allstates.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_clippath.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_pathobject.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_textobject.cpp View 8 chunks +11 lines, -11 lines 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_textstate.h View 1 chunk +14 lines, -0 lines 0 comments Download
A core/fpdfapi/fpdf_page/cpdf_textstate.cpp View 1 chunk +47 lines, -0 lines 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_textstatedata.cpp View 1 chunk +0 lines, -35 lines 0 comments Download
M core/fpdfapi/fpdf_page/fpdf_page_parser.cpp View 4 chunks +7 lines, -7 lines 0 comments Download
M core/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M core/fpdfapi/fpdf_page/include/cpdf_path.h View 2 chunks +19 lines, -0 lines 0 comments Download
M core/fpdfapi/fpdf_page/include/cpdf_textstatedata.h View 1 chunk +0 lines, -12 lines 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render_text.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M core/fpdftext/cpdf_textpage.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/fpdf_transformpage.cpp View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Tom Sepez
4 years, 3 months ago (2016-08-29 21:10:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2291833002/1
4 years, 3 months ago (2016-08-29 21:11:06 UTC) #3
commit-bot: I haz the power
4 years, 3 months ago (2016-08-29 21:27:20 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/596014357f7cd9ee3245ba8ed52cbc576115...

Powered by Google App Engine
This is Rietveld 408576698