Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2291823002: Converted Observatory function-view element (Closed)

Created:
4 years, 3 months ago by cbernaschina
Modified:
4 years, 3 months ago
Reviewers:
turnidge, rmacnak, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comment #

Patch Set 3 : Updated observatory_sources.gypi #

Unified diffs Side-by-side diffs Delta from patch set Stats (+444 lines, -166 lines) Patch
M runtime/observatory/lib/elements.dart View 4 chunks +3 lines, -1 line 0 comments Download
M runtime/observatory/lib/elements.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/models.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/repositories.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/app/page.dart View 2 chunks +15 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/field_view.dart View 2 chunks +5 lines, -4 lines 0 comments Download
M runtime/observatory/lib/src/elements/function_view.dart View 1 1 chunk +383 lines, -8 lines 0 comments Download
D runtime/observatory/lib/src/elements/function_view.html View 1 chunk +0 lines, -126 lines 0 comments Download
M runtime/observatory/lib/src/elements/service_view.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/observatory/lib/src/elements/service_view.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/models/objects/function.dart View 1 chunk +13 lines, -0 lines 0 comments Download
A + runtime/observatory/lib/src/models/repositories/function.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/repositories/context.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/repositories/field.dart View 1 chunk +0 lines, -2 lines 0 comments Download
A + runtime/observatory/lib/src/repositories/function.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/observatory/lib/src/repositories/icdata.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/repositories/instance.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/repositories/objectpool.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/repositories/reachable_size.dart View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/repositories/retained_size.dart View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/repositories/retaining_path.dart View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/repositories/script.dart View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/observatory_sources.gypi View 1 2 3 chunks +2 lines, -1 line 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/objects/function.dart View 1 chunk +16 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
cbernaschina
4 years, 3 months ago (2016-08-29 21:00:13 UTC) #2
rmacnak
lgtm https://chromiumcodereview.appspot.com/2291823002/diff/1/runtime/observatory/lib/src/elements/function_view.dart File runtime/observatory/lib/src/elements/function_view.dart (right): https://chromiumcodereview.appspot.com/2291823002/diff/1/runtime/observatory/lib/src/elements/function_view.dart#newcode179 runtime/observatory/lib/src/elements/function_view.dart:179: new NavClassMenuElement(_isolate, _function.dartOwner, queue: _r.queue), stray trailing comma
4 years, 3 months ago (2016-08-29 23:34:35 UTC) #3
cbernaschina
https://codereview.chromium.org/2291823002/diff/1/runtime/observatory/lib/src/elements/function_view.dart File runtime/observatory/lib/src/elements/function_view.dart (right): https://codereview.chromium.org/2291823002/diff/1/runtime/observatory/lib/src/elements/function_view.dart#newcode179 runtime/observatory/lib/src/elements/function_view.dart:179: new NavClassMenuElement(_isolate, _function.dartOwner, queue: _r.queue), On 2016/08/29 23:34:35, rmacnak ...
4 years, 3 months ago (2016-08-29 23:36:16 UTC) #4
cbernaschina
4 years, 3 months ago (2016-08-29 23:39:33 UTC) #5
cbernaschina
4 years, 3 months ago (2016-08-29 23:39:47 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
b63546ac574d52858e7a16a7e6bd8c0d20707fd9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698