Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Unified Diff: runtime/observatory/lib/src/app/page.dart

Issue 2291823002: Converted Observatory function-view element (Closed)
Patch Set: Updated observatory_sources.gypi Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/lib/repositories.dart ('k') | runtime/observatory/lib/src/elements/field_view.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/lib/src/app/page.dart
diff --git a/runtime/observatory/lib/src/app/page.dart b/runtime/observatory/lib/src/app/page.dart
index cf3b19fc95cf036a1ae2f7b2ba9ce07a988a9900..cd2b0cd4c55189a05454105ba70cba4be03ed6e5 100644
--- a/runtime/observatory/lib/src/app/page.dart
+++ b/runtime/observatory/lib/src/app/page.dart
@@ -9,6 +9,7 @@ AllocationProfileRepository _allocationProfileRepository
ClassRepository _classRepository = new ClassRepository();
ContextRepository _contextRepository = new ContextRepository();
FieldRepository _fieldRepository = new FieldRepository();
+FunctionRepository _functionRepository = new FunctionRepository();
HeapSnapshotRepository _heapSnapshotRepository
= new HeapSnapshotRepository();
ICDataRepository _icdataRepository = new ICDataRepository();
@@ -225,6 +226,20 @@ class InspectPage extends MatchingPage {
_instanceRepository,
queue: app.queue)
];
+ } else if (obj is ServiceFunction) {
+ container.children = [
+ new FunctionViewElement(app.vm, obj.isolate, obj, app.events,
+ app.notifications,
+ _functionRepository,
+ _classRepository,
+ _retainedSizeRepository,
+ _reachableSizeRepository,
+ _inboundReferencesRepository,
+ _retainingPathRepository,
+ _scriptRepository,
+ _instanceRepository,
+ queue: app.queue)
+ ];
} else if (obj is ICData) {
container.children = [
new ICDataViewElement(app.vm, obj.isolate, obj, app.events,
« no previous file with comments | « runtime/observatory/lib/repositories.dart ('k') | runtime/observatory/lib/src/elements/field_view.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698