Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2291793003: Fix paint invalidation and painting for composited-scrolling input elements. (Closed)

Created:
4 years, 3 months ago by chrishtr
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Fix paint invalidation and painting for composited-scrolling input elements. In, particular, the following issues: 1. Paint invalidation missed cases when elements had "intrinsic scrollability", in particular input elements. 2. Invalidation of carets incorrectly included scrolling for composited input elements. 3. The DisplayItemClient must be distinct for case #2, because it paints into a different GraphicsLayer than the rest of the LayoutBlock. BUG=635724 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2271883002 Cr-Commit-Position: refs/heads/master@{#415013} (cherry picked from commit b1d694f3370e4b6d6e723382c086617f85c94e93) Committed: https://chromium.googlesource.com/chromium/src/+/096f5bf603212251bff19486f9d487e0c8a4f123

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+489 lines, -27 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +12 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/invalidate-caret-in-composited-scrolling-container.html View 1 chunk +21 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/invalidate-caret-in-composited-scrolling-container-expected.txt View 1 chunk +92 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/invalidate-caret-in-non-composited-scrolling-container.html View 1 chunk +21 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/invalidation/invalidate-caret-in-non-composited-scrolling-container-expected.txt View 1 chunk +79 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/selection/selection-in-composited-scrolling-container.html View 1 chunk +18 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/selection/selection-in-composited-scrolling-container-expected.txt View 1 chunk +108 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/selection/selection-in-non-composited-scrolling-container.html View 1 chunk +18 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/paint/selection/selection-in-non-composited-scrolling-container-expected.txt View 1 chunk +78 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/CaretBase.h View 3 chunks +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/CaretBase.cpp View 5 chunks +21 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/editing/DragCaretController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/FrameCaret.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BlockPainter.cpp View 2 chunks +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp View 2 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DisplayItem.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
chrishtr
4 years, 3 months ago (2016-08-29 22:58:24 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
096f5bf603212251bff19486f9d487e0c8a4f123.

Powered by Google App Engine
This is Rietveld 408576698