Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Side by Side Diff: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

Issue 2291793003: Fix paint invalidation and painting for composited-scrolling input elements. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 4 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
5 * 5 *
6 * Other contributors: 6 * Other contributors:
7 * Robert O'Callahan <roc+@cs.cmu.edu> 7 * Robert O'Callahan <roc+@cs.cmu.edu>
8 * David Baron <dbaron@fas.harvard.edu> 8 * David Baron <dbaron@fas.harvard.edu>
9 * Christian Biesinger <cbiesinger@gmail.com> 9 * Christian Biesinger <cbiesinger@gmail.com>
10 * Randall Jesup <rjesup@wgate.com> 10 * Randall Jesup <rjesup@wgate.com>
(...skipping 1451 matching lines...) Expand 10 before | Expand all | Expand 10 after
1462 layer()->compositedLayerMapping()->setNeedsGraphicsLayerUpdate(Graph icsLayerUpdateSubtree); 1462 layer()->compositedLayerMapping()->setNeedsGraphicsLayerUpdate(Graph icsLayerUpdateSubtree);
1463 compositor->setNeedsCompositingUpdate(CompositingUpdateAfterGeometry Change); 1463 compositor->setNeedsCompositingUpdate(CompositingUpdateAfterGeometry Change);
1464 } else { 1464 } else {
1465 layer()->setNeedsCompositingInputsUpdate(); 1465 layer()->setNeedsCompositingInputsUpdate();
1466 } 1466 }
1467 } 1467 }
1468 } 1468 }
1469 1469
1470 bool PaintLayerScrollableArea::usesCompositedScrolling() const 1470 bool PaintLayerScrollableArea::usesCompositedScrolling() const
1471 { 1471 {
1472 // Scroll form controls on the main thread so they exhibit correct touch scr oll event bubbling
1473 if (box().isIntrinsicallyScrollable(VerticalScrollbar) || box().isIntrinsica llyScrollable(HorizontalScrollbar))
1474 return false;
1475
1476 // See https://codereview.chromium.org/176633003/ for the tests that fail wi thout this disabler. 1472 // See https://codereview.chromium.org/176633003/ for the tests that fail wi thout this disabler.
1477 DisableCompositingQueryAsserts disabler; 1473 DisableCompositingQueryAsserts disabler;
1478 return layer()->hasCompositedLayerMapping() && layer()->compositedLayerMappi ng()->scrollingLayer(); 1474 return layer()->hasCompositedLayerMapping() && layer()->compositedLayerMappi ng()->scrollingLayer();
1479 } 1475 }
1480 1476
1481 bool PaintLayerScrollableArea::shouldScrollOnMainThread() const 1477 bool PaintLayerScrollableArea::shouldScrollOnMainThread() const
1482 { 1478 {
1483 if (LocalFrame* frame = box().frame()) { 1479 if (LocalFrame* frame = box().frame()) {
1484 if (Page* page = frame->page()) { 1480 if (Page* page = frame->page()) {
1485 if (page->scrollingCoordinator()->shouldUpdateScrollLayerPositionOnM ainThread()) 1481 if (page->scrollingCoordinator()->shouldUpdateScrollLayerPositionOnM ainThread())
(...skipping 286 matching lines...) Expand 10 before | Expand all | Expand 10 after
1772 1768
1773 void PaintLayerScrollableArea::DelayScrollPositionClampScope::clampScrollableAre as() 1769 void PaintLayerScrollableArea::DelayScrollPositionClampScope::clampScrollableAre as()
1774 { 1770 {
1775 for (auto& scrollableArea : *s_needsClamp) 1771 for (auto& scrollableArea : *s_needsClamp)
1776 scrollableArea->clampScrollPositionsAfterLayout(); 1772 scrollableArea->clampScrollPositionsAfterLayout();
1777 delete s_needsClamp; 1773 delete s_needsClamp;
1778 s_needsClamp = nullptr; 1774 s_needsClamp = nullptr;
1779 } 1775 }
1780 1776
1781 } // namespace blink 1777 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698