Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2291463003: Revert "CC Animation: Introduce some dirty flags to optimize PushProperties on commit" (Closed)

Created:
4 years, 3 months ago by lazyboy
Modified:
4 years, 3 months ago
Reviewers:
danakj, loyso (OOO), ajuma
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "CC Animation: Introduce some dirty flags to optimize PushProperties on commit" This reverts commit 1ec9dd4962683e1fe12734a6756e825df2db10ca. Reason for revert: Since build https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/45513, PluginPowerSaver.PosterTests and PluginPowerSaver.SmallerThanPlayIcon started flaking, timing out in VerifySnapshot: https://cs.chromium.org/chromium/src/chrome/browser/plugins/plugin_power_saver_browsertest.cc?sq=package:chromium&dr=CSs&rcl=1472469725&l=359 Speculatively reverting to see if that helps... Original issue's description: > CC Animation: Introduce some dirty flags to optimize PushProperties on commit > > The idea is that we invalidate needs_push_properties flag > from bottom-to-top in the hierarchy of ownership. > > It helps us to isolate untouched groups of objects. > > BUG=604280 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel > > Committed: https://crrev.com/1ec9dd4962683e1fe12734a6756e825df2db10ca > Cr-Commit-Position: refs/heads/master@{#414981} TBR=ajuma@chromium.org,danakj@chromium.org,loyso@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=604280 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://chromium.googlesource.com/chromium/src/+/71b649adfb413b078a5fa6519627af90a203640e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -291 lines) Patch
M cc/animation/animation_host.h View 3 chunks +8 lines, -3 lines 0 comments Download
M cc/animation/animation_host.cc View 6 chunks +24 lines, -33 lines 0 comments Download
M cc/animation/animation_host_perftest.cc View 6 chunks +15 lines, -42 lines 0 comments Download
M cc/animation/animation_player.h View 3 chunks +2 lines, -5 lines 0 comments Download
M cc/animation/animation_player.cc View 8 chunks +14 lines, -32 lines 0 comments Download
M cc/animation/animation_player_unittest.cc View 14 chunks +1 line, -49 lines 0 comments Download
M cc/animation/animation_timeline.h View 2 chunks +0 lines, -4 lines 0 comments Download
M cc/animation/animation_timeline.cc View 6 chunks +8 lines, -33 lines 0 comments Download
M cc/animation/element_animations.h View 5 chunks +4 lines, -6 lines 0 comments Download
M cc/animation/element_animations.cc View 11 chunks +13 lines, -27 lines 0 comments Download
M cc/animation/element_animations_unittest.cc View 9 chunks +14 lines, -24 lines 0 comments Download
M cc/animation/scroll_offset_animations.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/test/animation_timelines_test_common.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/test/animation_timelines_test_common.cc View 1 chunk +0 lines, -29 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/71b649adfb413b078a5fa6519627af90a203640e Cr-Commit-Position: refs/heads/master@{#415040}
4 years, 3 months ago (2016-08-29 23:55:47 UTC) #3
lazyboy
4 years, 3 months ago (2016-08-29 23:56:58 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
71b649adfb413b078a5fa6519627af90a203640e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698