Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2978)

Unified Diff: cc/animation/animation_player.h

Issue 2291463003: Revert "CC Animation: Introduce some dirty flags to optimize PushProperties on commit" (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/animation/animation_host_perftest.cc ('k') | cc/animation/animation_player.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/animation/animation_player.h
diff --git a/cc/animation/animation_player.h b/cc/animation/animation_player.h
index 6735e0e29ec9e82100c0ae41c8c85223ac45d278..5c4c58e94db4c7fdf3ed8f220b668a02b29b8fe7 100644
--- a/cc/animation/animation_player.h
+++ b/cc/animation/animation_player.h
@@ -82,7 +82,6 @@ class CC_EXPORT AnimationPlayer : public base::RefCounted<AnimationPlayer> {
void NotifyAnimationAborted(base::TimeTicks monotonic_time,
TargetProperty::Type target_property,
int group);
- void NotifyAnimationWaitingForDeletion();
void NotifyAnimationTakeover(base::TimeTicks monotonic_time,
TargetProperty::Type target_property,
double animation_start_time,
@@ -93,15 +92,14 @@ class CC_EXPORT AnimationPlayer : public base::RefCounted<AnimationPlayer> {
return !animations_.empty();
}
- bool needs_push_properties() const { return needs_push_properties_; }
- void SetNeedsPushProperties();
-
private:
friend class base::RefCounted<AnimationPlayer>;
explicit AnimationPlayer(int id);
~AnimationPlayer();
+ void SetNeedsCommit();
+
void RegisterPlayer();
void UnregisterPlayer();
@@ -121,7 +119,6 @@ class CC_EXPORT AnimationPlayer : public base::RefCounted<AnimationPlayer> {
int id_;
ElementId element_id_;
- bool needs_push_properties_;
DISALLOW_COPY_AND_ASSIGN(AnimationPlayer);
};
« no previous file with comments | « cc/animation/animation_host_perftest.cc ('k') | cc/animation/animation_player.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698