Issue 2291303002: [bisect] Add service account parameter to buildbucket.get_build calls.

Issue 2291303002: [bisect] Add service account parameter to buildbucket.get_build calls. (Closed)

Created:
4 years, 3 months ago by RobertoCN

Modified:
4 years, 3 months ago

Reviewers:
Vadim Sh., prasadv

CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master

Target Ref:
refs/heads/master

Project:
build

Visibility:
Public.

[bisect] Add service account parameter to buildbucket.get_build calls. Bisect is_build_failed calls were missing the service account parameter. R=prasadv,vadimsh@chromium.org BUG=642431 Committed: https://chromium.googlesource.com/chromium/tools/build/+/ff87b14bc50cb9e2b4e364cebcc1773396d1f4a0

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -2 lines)			Patch
M	scripts/slave/recipe_modules/auto_bisect/example.expected/delayed_build_test.json	View	4 chunks	+8 lines, -0 lines	0 comments	Download
M	scripts/slave/recipe_modules/auto_bisect/example.expected/failed_build_test.json	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	scripts/slave/recipe_modules/auto_bisect/revision_state.py	View	1 chunk	+4 lines, -2 lines	0 comments	Download

Total messages: 6 (2 generated)

Vadim Sh.

lgtm We also need to actually allow this account to read builds.

4 years, 3 months ago (2016-08-30 18:40:12 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2291303002/1

4 years, 3 months ago (2016-08-30 20:54:40 UTC) #4

commit-bot: I haz the power

4 years, 3 months ago (2016-08-30 20:58:35 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/ff87b14bc50cb9e2b4e3...