scripts/slave/recipe_modules/auto_bisect/revision_state.py - Issue 2291303002: [bisect] Add service account parameter to buildbucket.get_build calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/auto_bisect/revision_state.py

Issue 2291303002: [bisect] Add service account parameter to buildbucket.get_build calls. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: scripts/slave/recipe_modules/auto_bisect/revision_state.py

diff --git a/scripts/slave/recipe_modules/auto_bisect/revision_state.py b/scripts/slave/recipe_modules/auto_bisect/revision_state.py

index 0cb4659aa648ee0238dfcdc8225df45465f1ff14..4e0644bc4e14f7b9ef344d2258b9cfc6353f2b4d 100644

--- a/scripts/slave/recipe_modules/auto_bisect/revision_state.py

+++ b/scripts/slave/recipe_modules/auto_bisect/revision_state.py

@@ -281,9 +281,11 @@ class RevisionState(object):

return self.build_archived

def _is_build_failed(self):

- result = self.bisector.api.m.buildbucket.get_build(

+ api = self.bisector.api

+ result = api.m.buildbucket.get_build(

self.build_id,

- step_test_data=lambda: self.bisector.api.m.json.test_api.output_stream(

+ api.m.service_account.get_json_path(api.SERVICE_ACCOUNT),

+ step_test_data=lambda: api.m.json.test_api.output_stream(

{'build': {'result': 'SUCCESS', 'status': 'COMPLETED'}}

))

return (result.stdout['build']['status'] == 'COMPLETED' and

« no previous file with comments | « scripts/slave/recipe_modules/auto_bisect/example.expected/failed_build_test.json ('k') | no next file » | no next file with comments »