Revert of Rework default GN symbol handling for win goma builds.

Revert of Rework default GN symbol handling for win goma builds. (patchset #4 id:100001 of https://codereview.chromium.org/2215433002/ )

Reason for revert:
reverting, this breaks non-goma win builds since use_goma is undefined (i.e., I missed an import).

Original issue's description:
> Rework default GN symbol handling for win goma builds.
> 
> Win goma builds do not support PDB files, so trying to build with
> full symbols is very painful. Previously we would default to "full
> symbols" but silently turn off symbols if using goma; this CL
> restructures things so that we default to "minimal symbols" if
> using goma (and visual studio's compiler).
> 
> R=brucedawson@chromium.org, brettw@chromium.org, thakis@chromium.org
> BUG=634184
> 
> Committed: https://crrev.com/64fea5e29655036e2c5410b903cd43f832d04e93
> Cr-Commit-Position: refs/heads/master@{#415325}

TBR=brettw@chromium.org,brucedawson@chromium.org,thakis@chromium.org,scottmg@chromium.org,jam@chromium.org,rnk@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=634184

[Dirk Pranke, 2016-08-30 18:24:17]

The CQ bit was checked by dpranke@chromium.org

[Dirk Pranke, 2016-08-30 18:24:19]

Created Revert of Rework default GN symbol handling for win goma builds.

[commit-bot: I haz the power, 2016-08-30 18:25:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 18:26:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 18:26:29]

Failed to apply patch for build/config/compiler/BUILD.gn:
While running git apply --index -3 -p1;
  error: patch failed: build/config/compiler/BUILD.gn:1508
  error: repository lacks the necessary blob to fall back on 3-way merge.
  error: build/config/compiler/BUILD.gn: patch does not apply

Patch:       build/config/compiler/BUILD.gn
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index
9b1f99cc2a676b80736926c46249b89a0e135261..d0daf4f3d7ccfb5853a859ea9d21e5620b938f2d
100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -1508,8 +1508,14 @@
 config("symbols") {
   if (is_win) {
     import("//build/toolchain/goma.gni")
-    cflags = [ "/Zi" ]  # Produce PDB file, no edit and continue.
-
+    if (use_goma) {
+      # Disable symbols during goma compilation because otherwise the redundant
+      # debug information (repeated in every .obj file) makes linker memory
+      # consumption and link times unsustainable (crbug.com/630074).
+      cflags = []
+    } else {
+      cflags = [ "/Zi" ]  # Produce PDB file, no edit and continue.
+    }
     if (is_win_fastlink && visual_studio_version != "2013") {
       # Tell VS 2015+ to create a PDB that references debug
       # information in .obj and .lib files instead of copying

[Dirk Pranke, 2016-08-30 18:27:32]

Patch was already reverted, closing.

[Dirk Pranke, 2016-08-30 18:27:39]

Description was changed from

==========
Revert of Rework default GN symbol handling for win goma builds. (patchset #4
id:100001 of https://codereview.chromium.org/2215433002/ )

Reason for revert:
reverting, this breaks non-goma win builds since use_goma is undefined (i.e., I
missed an import).

Original issue's description:
> Rework default GN symbol handling for win goma builds.
> 
> Win goma builds do not support PDB files, so trying to build with
> full symbols is very painful. Previously we would default to "full
> symbols" but silently turn off symbols if using goma; this CL
> restructures things so that we default to "minimal symbols" if
> using goma (and visual studio's compiler).
> 
> R=brucedawson@chromium.org, brettw@chromium.org, thakis@chromium.org
> BUG=634184
> 
> Committed: https://crrev.com/64fea5e29655036e2c5410b903cd43f832d04e93
> Cr-Commit-Position: refs/heads/master@{#415325}

TBR=brettw@chromium.org,brucedawson@chromium.org,thakis@chromium.org,scottmg@...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=634184
==========

to

==========
Revert of Rework default GN symbol handling for win goma builds. (patchset #4
id:100001 of https://codereview.chromium.org/2215433002/ )

Reason for revert:
reverting, this breaks non-goma win builds since use_goma is undefined (i.e., I
missed an import).

Original issue's description:
> Rework default GN symbol handling for win goma builds.
> 
> Win goma builds do not support PDB files, so trying to build with
> full symbols is very painful. Previously we would default to "full
> symbols" but silently turn off symbols if using goma; this CL
> restructures things so that we default to "minimal symbols" if
> using goma (and visual studio's compiler).
> 
> R=brucedawson@chromium.org, brettw@chromium.org, thakis@chromium.org
> BUG=634184
> 
> Committed: https://crrev.com/64fea5e29655036e2c5410b903cd43f832d04e93
> Cr-Commit-Position: refs/heads/master@{#415325}

TBR=brettw@chromium.org,brucedawson@chromium.org,thakis@chromium.org,scottmg@...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=634184
==========