Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Unified Diff: build/config/compiler/BUILD.gn

Issue 2291293002: Revert of Rework default GN symbol handling for win goma builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/config/compiler/compiler.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index 9b1f99cc2a676b80736926c46249b89a0e135261..d0daf4f3d7ccfb5853a859ea9d21e5620b938f2d 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -1508,8 +1508,14 @@
config("symbols") {
if (is_win) {
import("//build/toolchain/goma.gni")
- cflags = [ "/Zi" ] # Produce PDB file, no edit and continue.
-
+ if (use_goma) {
+ # Disable symbols during goma compilation because otherwise the redundant
+ # debug information (repeated in every .obj file) makes linker memory
+ # consumption and link times unsustainable (crbug.com/630074).
+ cflags = []
+ } else {
+ cflags = [ "/Zi" ] # Produce PDB file, no edit and continue.
+ }
if (is_win_fastlink && visual_studio_version != "2013") {
# Tell VS 2015+ to create a PDB that references debug
# information in .obj and .lib files instead of copying
« no previous file with comments | « no previous file | build/config/compiler/compiler.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698