Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2291233002: Converted Observatory instance-view element (Closed)

Created:
4 years, 3 months ago by cbernaschina
Modified:
4 years, 3 months ago
Reviewers:
turnidge, rmacnak, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fixed service tests #

Total comments: 4

Patch Set 3 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1145 lines, -507 lines) Patch
M runtime/observatory/lib/elements.dart View 7 chunks +6 lines, -1 line 0 comments Download
M runtime/observatory/lib/elements.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/models.dart View 3 chunks +3 lines, -1 line 0 comments Download
M runtime/observatory/lib/repositories.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/app/page.dart View 4 chunks +26 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/context_ref.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/context_ref_wrapper.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/context_view.dart View 2 chunks +8 lines, -8 lines 0 comments Download
M runtime/observatory/lib/src/elements/css/shared.css View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/eval_box_wrapper.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/icdata_ref.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/instance_ref.dart View 1 2 9 chunks +11 lines, -35 lines 0 comments Download
M runtime/observatory/lib/src/elements/instance_ref_wrapper.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/instance_view.dart View 1 chunk +670 lines, -25 lines 0 comments Download
D runtime/observatory/lib/src/elements/instance_view.html View 1 chunk +0 lines, -365 lines 0 comments Download
M runtime/observatory/lib/src/elements/megamorphiccache_ref.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/objectpool_ref.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
A runtime/observatory/lib/src/elements/sentinel_view.dart View 1 chunk +122 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/service_view.dart View 1 chunk +3 lines, -10 lines 0 comments Download
M runtime/observatory/lib/src/elements/service_view.html View 1 chunk +0 lines, -1 line 0 comments Download
D runtime/observatory/lib/src/models/objects/bound_field.dart View 1 chunk +0 lines, -10 lines 0 comments Download
M runtime/observatory/lib/src/models/objects/instance.dart View 4 chunks +119 lines, -1 line 0 comments Download
A runtime/observatory/lib/src/models/objects/type_arguments.dart View 1 chunk +18 lines, -0 lines 0 comments Download
A + runtime/observatory/lib/src/models/repositories/breakpoint.dart View 1 chunk +3 lines, -2 lines 0 comments Download
A + runtime/observatory/lib/src/models/repositories/type_arguments.dart View 1 chunk +2 lines, -3 lines 0 comments Download
A runtime/observatory/lib/src/repositories/breakpoint.dart View 1 chunk +18 lines, -0 lines 0 comments Download
A + runtime/observatory/lib/src/repositories/type_arguments.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 1 2 11 chunks +49 lines, -11 lines 0 comments Download
M runtime/observatory/lib/utils.dart View 1 chunk +26 lines, -0 lines 0 comments Download
M runtime/observatory/observatory_sources.gypi View 6 chunks +6 lines, -2 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/objects/instance.dart View 2 chunks +27 lines, -5 lines 0 comments Download
M runtime/observatory/tests/service/contexts_test.dart View 4 chunks +12 lines, -12 lines 0 comments Download
M runtime/observatory/tests/service/type_arguments_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
cbernaschina
4 years, 3 months ago (2016-08-30 16:50:38 UTC) #2
cbernaschina
4 years, 3 months ago (2016-08-30 18:19:02 UTC) #3
turnidge
lgtm after you fix two things... https://codereview.chromium.org/2291233002/diff/20001/runtime/observatory/lib/src/elements/instance_ref.dart File runtime/observatory/lib/src/elements/instance_ref.dart (right): https://codereview.chromium.org/2291233002/diff/20001/runtime/observatory/lib/src/elements/instance_ref.dart#newcode138 runtime/observatory/lib/src/elements/instance_ref.dart:138: new SpanElement()..classes = ...
4 years, 3 months ago (2016-08-30 21:31:16 UTC) #4
cbernaschina
https://codereview.chromium.org/2291233002/diff/20001/runtime/observatory/lib/src/elements/instance_ref.dart File runtime/observatory/lib/src/elements/instance_ref.dart (right): https://codereview.chromium.org/2291233002/diff/20001/runtime/observatory/lib/src/elements/instance_ref.dart#newcode138 runtime/observatory/lib/src/elements/instance_ref.dart:138: new SpanElement()..classes = const ['empathize'] On 2016/08/30 21:31:16, turnidge ...
4 years, 3 months ago (2016-08-30 21:44:49 UTC) #5
cbernaschina
4 years, 3 months ago (2016-08-30 21:53:32 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
bf7d2207410a1cbb3c31360c72cc946ff672e70f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698