Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Unified Diff: runtime/observatory/lib/src/app/page.dart

Issue 2291233002: Converted Observatory instance-view element (Closed)
Patch Set: Addressed comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/lib/repositories.dart ('k') | runtime/observatory/lib/src/elements/context_ref.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/lib/src/app/page.dart
diff --git a/runtime/observatory/lib/src/app/page.dart b/runtime/observatory/lib/src/app/page.dart
index cd2b0cd4c55189a05454105ba70cba4be03ed6e5..d001cedf4a2c3a46777030855dd48defdcf51b0f 100644
--- a/runtime/observatory/lib/src/app/page.dart
+++ b/runtime/observatory/lib/src/app/page.dart
@@ -6,8 +6,10 @@ part of app;
AllocationProfileRepository _allocationProfileRepository
= new AllocationProfileRepository();
+BreakpointRepository _breakpointRepository = new BreakpointRepository();
ClassRepository _classRepository = new ClassRepository();
ContextRepository _contextRepository = new ContextRepository();
+EvalRepository _evalRepository = new EvalRepository();
FieldRepository _fieldRepository = new FieldRepository();
FunctionRepository _functionRepository = new FunctionRepository();
HeapSnapshotRepository _heapSnapshotRepository
@@ -28,6 +30,8 @@ PersistentHandlesRepository _persistentHandlesRepository
= new PersistentHandlesRepository();
PortsRepository _portsRepository = new PortsRepository();
ScriptRepository _scriptRepository = new ScriptRepository();
+TypeArgumentsRepository _typeArgumentsRepository
+ = new TypeArgumentsRepository();
class IsolateNotFound implements Exception {
String isolateId;
@@ -226,6 +230,23 @@ class InspectPage extends MatchingPage {
_instanceRepository,
queue: app.queue)
];
+ } else if (obj is Instance) {
+ container.children = [
+ new InstanceViewElement(app.vm, obj.isolate, obj, app.events,
+ app.notifications,
+ _instanceRepository,
+ _classRepository,
+ _retainedSizeRepository,
+ _reachableSizeRepository,
+ _inboundReferencesRepository,
+ _retainingPathRepository,
+ _scriptRepository,
+ _evalRepository,
+ _typeArgumentsRepository,
+ _breakpointRepository,
+ _functionRepository,
+ queue: app.queue)
+ ];
} else if (obj is ServiceFunction) {
container.children = [
new FunctionViewElement(app.vm, obj.isolate, obj, app.events,
@@ -294,6 +315,11 @@ class InspectPage extends MatchingPage {
_instanceRepository,
pos: pos, queue: app.queue)
];
+ } else if (obj is Sentinel) {
+ container.children = [
+ new SentinelViewElement(app.vm, obj.isolate, obj, app.events,
+ app.notifications, queue: app.queue)
+ ];
} else {
ServiceObjectViewElement serviceElement =new Element.tag('service-view');
serviceElement.object = obj;
« no previous file with comments | « runtime/observatory/lib/repositories.dart ('k') | runtime/observatory/lib/src/elements/context_ref.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698