Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 2291203002: Remove custom data from GrGpuResource (Closed)

Created:
4 years, 3 months ago by bsalomon
Modified:
4 years, 3 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove custom data from GrGpuResource Chrome is no longer relying on this feature to track mailboxes for textures. BUG=skia:4134 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2291203002 Committed: https://skia.googlesource.com/skia/+/9a44565e9946629c4ee776fb859d168eb953da71

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -25 lines) Patch
M include/gpu/GrGpuResource.h View 3 chunks +0 lines, -17 lines 0 comments Download
M src/gpu/GrGpuResource.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M tests/ResourceCacheTest.cpp View 1 chunk +0 lines, -2 lines 3 comments Download

Messages

Total messages: 15 (7 generated)
bsalomon
4 years, 3 months ago (2016-08-30 16:17:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2291203002/1
4 years, 3 months ago (2016-08-30 16:17:26 UTC) #6
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
4 years, 3 months ago (2016-08-30 16:17:27 UTC) #7
robertphillips
https://codereview.chromium.org/2291203002/diff/1/tests/ResourceCacheTest.cpp File tests/ResourceCacheTest.cpp (right): https://codereview.chromium.org/2291203002/diff/1/tests/ResourceCacheTest.cpp#newcode1258 tests/ResourceCacheTest.cpp:1258: how is this test working ? https://codereview.chromium.org/2291203002/diff/1/tests/ResourceCacheTest.cpp#newcode1282 tests/ResourceCacheTest.cpp:1282: Can ...
4 years, 3 months ago (2016-08-30 16:38:37 UTC) #8
robertphillips
https://codereview.chromium.org/2291203002/diff/1/tests/ResourceCacheTest.cpp File tests/ResourceCacheTest.cpp (right): https://codereview.chromium.org/2291203002/diff/1/tests/ResourceCacheTest.cpp#newcode1258 tests/ResourceCacheTest.cpp:1258: On 2016/08/30 16:38:37, robertphillips wrote: > how is this ...
4 years, 3 months ago (2016-08-30 16:39:41 UTC) #9
robertphillips
Otherwise, lgtm
4 years, 3 months ago (2016-08-30 16:41:03 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2291203002/1
4 years, 3 months ago (2016-08-30 16:41:47 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 16:42:34 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/9a44565e9946629c4ee776fb859d168eb953da71

Powered by Google App Engine
This is Rietveld 408576698