Remove custom data from GrGpuResource

tests/ResourceCacheTest.cpp

 /*
  * Copyright 2013 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 // Include here to ensure SK_SUPPORT_GPU is set correctly before it is examined.
 #include "SkTypes.h"
 
@@ skipping 1237 matching lines @@
 
     for (int i = 0; i < kResourceCnt; ++i) {
         GrUniqueKey key1, key2;
         make_unique_key<1>(&key1, i);
         make_unique_key<2>(&key2, i);
 
         REPORTER_ASSERT(reporter, !cache->hasUniqueKey(key1));
         REPORTER_ASSERT(reporter, !cache->hasUniqueKey(key2));
     }
 }
 

[robertphillips, 2016/08/30 16:38:37]

how is this test working ?

[robertphillips, 2016/08/30 16:39:41]

Nevermind, this is the key's custom data.

 static void test_custom_data(skiatest::Reporter* reporter) {
     GrUniqueKey key1, key2;
     make_unique_key<0>(&key1, 1);
     make_unique_key<0>(&key2, 2);
     int foo = 4132;
     key1.setCustomData(SkData::MakeWithCopy(&foo, sizeof(foo)));
     REPORTER_ASSERT(reporter, *(int*) key1.getCustomData()->data() == 4132);
     REPORTER_ASSERT(reporter, key2.getCustomData() == nullptr);
 
     // Test that copying a key also takes a ref on its custom data.
     GrUniqueKey key3 = key1;
     REPORTER_ASSERT(reporter, *(int*) key3.getCustomData()->data() == 4132);
 }
 
 static void test_abandoned(skiatest::Reporter* reporter) {
     Mock mock(10, 300);
     GrContext* context = mock.context();
     SkAutoTUnref<GrGpuResource> resource(new TestResource(context->getGpu()));
     context->abandonContext();
 
     REPORTER_ASSERT(reporter, resource->wasDestroyed());
 
     // Call all the public methods on resource in the abandoned state. They shouldn't crash.
 

[robertphillips, 2016/08/30 16:38:37]

Can we rm foo & data too ?

     int foo = 4132;
     sk_sp<SkData> data(SkData::MakeWithCopy(&foo, sizeof(foo)));
-    resource->setCustomData(data.get());
-    resource->getCustomData();
     resource->getUniqueID();
     resource->getUniqueKey();
     resource->wasDestroyed();
     resource->gpuMemorySize();
     resource->getContext();
 
     resource->abandon();
     resource->resourcePriv().getScratchKey();
     resource->resourcePriv().isBudgeted();
     resource->resourcePriv().makeBudgeted();
@@ skipping 19 matching lines @@
     test_cache_chained_purge(reporter);
     test_resource_size_changed(reporter);
     test_timestamp_wrap(reporter);
     test_flush(reporter);
     test_large_resource_count(reporter);
     test_custom_data(reporter);
     test_abandoned(reporter);
 }
 
 #endif