Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2291053002: Cleanup: remove non-standard retain_unknown_fields from .proto files (Closed)

Created:
4 years, 3 months ago by Paweł Hajdan Jr.
Modified:
4 years, 3 months ago
Reviewers:
xyzzyz, Nicolas Zea
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org, johnme+watch_chromium.org, Peter Beverloo, sync-reviews_chromium.org, zea+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup: remove non-standard retain_unknown_fields from .proto files It has no effect now anyway. TBR=zea BUG=none Committed: https://crrev.com/f86af7a7f0387478bd08256b70e536d7b00bddc8 Cr-Commit-Position: refs/heads/master@{#415933}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -47 lines) Patch
M components/sync/core_impl/attachments/proto/attachment_store.proto View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/protocol/app_list_specifics.proto View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/protocol/app_notification_specifics.proto View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/protocol/app_setting_specifics.proto View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/protocol/app_specifics.proto View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/protocol/arc_package_specifics.proto View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/protocol/article_specifics.proto View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/protocol/attachments.proto View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/protocol/autofill_specifics.proto View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/protocol/bookmark_specifics.proto View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/protocol/client_commands.proto View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/protocol/client_debug_info.proto View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/protocol/data_type_state.proto View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/protocol/device_info_specifics.proto View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/protocol/dictionary_specifics.proto View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/protocol/encryption.proto View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/protocol/entity_metadata.proto View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/protocol/experiments_specifics.proto View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/protocol/extension_setting_specifics.proto View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/protocol/extension_specifics.proto View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/protocol/favicon_image_specifics.proto View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/protocol/favicon_tracking_specifics.proto View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/protocol/get_updates_caller_info.proto View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/protocol/history_delete_directive_specifics.proto View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/protocol/history_status.proto View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/protocol/managed_user_setting_specifics.proto View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/protocol/managed_user_shared_setting_specifics.proto View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/protocol/managed_user_specifics.proto View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/protocol/managed_user_whitelist_specifics.proto View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/protocol/nigori_specifics.proto View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/protocol/password_specifics.proto View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/protocol/preference_specifics.proto View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/protocol/priority_preference_specifics.proto View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/protocol/search_engine_specifics.proto View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/protocol/session_specifics.proto View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/protocol/sync.proto View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/protocol/sync_enums.proto View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/protocol/synced_notification_app_info_specifics.proto View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/protocol/synced_notification_specifics.proto View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/protocol/test.proto View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/protocol/theme_specifics.proto View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/protocol/typed_url_specifics.proto View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/protocol/unique_position.proto View 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/protocol/wifi_credential_specifics.proto View 1 chunk +0 lines, -1 line 0 comments Download
M google_apis/gcm/protocol/android_checkin.proto View 1 chunk +0 lines, -1 line 0 comments Download
M google_apis/gcm/protocol/checkin.proto View 1 chunk +0 lines, -1 line 0 comments Download
M google_apis/gcm/protocol/mcs.proto View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
Paweł Hajdan Jr.
4 years, 3 months ago (2016-08-30 12:18:01 UTC) #4
xyzzyz
lgtm I should have cleaned that up a while ago but totally forgot ...
4 years, 3 months ago (2016-08-30 19:45:06 UTC) #7
Paweł Hajdan Jr.
+zea for OWNERS
4 years, 3 months ago (2016-08-31 09:28:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2291053002/1
4 years, 3 months ago (2016-09-01 10:57:04 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-01 11:43:06 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 11:44:23 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f86af7a7f0387478bd08256b70e536d7b00bddc8
Cr-Commit-Position: refs/heads/master@{#415933}

Powered by Google App Engine
This is Rietveld 408576698