DevTools: Create recipe and builder for devtools

scripts/slave/recipes/devtools.py

Index: scripts/slave/recipes/devtools.py
diff --git a/scripts/slave/recipes/devtools.py b/scripts/slave/recipes/devtools.py
new file mode 100644
index 0000000000000000000000000000000000000000..304ae4706da40ae46ba9deb06474041e302804c9
--- /dev/null
+++ b/scripts/slave/recipes/devtools.py
@@ -0,0 +1,51 @@
+from recipe_engine.types import freeze
+
+DEPS = [
+  'chromium_tests',
+  'depot_tools/bot_update',
+  'depot_tools/gclient',
+  'recipe_engine/path',
+  'recipe_engine/properties',
+  'recipe_engine/python',
+  'recipe_engine/step',
+]
+
+MASTERS = freeze({
+  'chromium.fyi': {
+    'buildername': 'Devtools',
+    'testname': 'devtools_fyi',
+  },
+})
+
+def RunSteps(api):
+  api.gclient.set_config('chromium')
+  api.bot_update.ensure_checkout(force=True)
+
+  has_devtools_file = False
+  files = api.chromium_tests.get_files_affected_by_patch()

[chenwilliam, 2016/08/30 01:27:55]

What I'm trying to do is figure out if the most recent patch has any devtools
files in it. I'm not sure if this is the right way.

[Ryan Tseng, 2016/08/30 18:13:39]

I'm not super familiar with this but it looks right.

+  for f in files:
+    if f.startswith('third_party/WebKit/Source/devtools'):
+      has_devtools_file = True
+
+  if not has_devtools_file:
+    api.step('skip checks', ['echo', 'no devtools file in patch'])
+    return
+
+  devtoolsPath = api.path['checkout'].join('third_party', 'WebKit', 'Source',

[Ryan Tseng, 2016/08/30 18:13:39]

Did you get any python coverage errors here? I don't think this line is covered.

[chenwilliam, 2016/09/01 18:00:44]

Added coverage.

+                                           'devtools')
+  npmPath = api.path['checkout'].join('third_party', 'WebKit', 'Source', 'devtools',

[Ryan Tseng, 2016/08/30 18:13:39]

80 char

[chenwilliam, 2016/09/01 18:00:44]

Done.

+                                      'scripts', 'nodejs', 'npm.py')

[Ryan Tseng, 2016/08/30 18:13:39]

where's this from? I can't find it

[chenwilliam, 2016/09/01 18:00:44]

Just landed in https://codereview.chromium.org/2278803004/

+
+  api.python('install node.js and npm', npmPath, ['--version'])
+  api.python('install eslint', npmPath, ['install', 'eslint@2'])
+  api.python('run eslint', npmPath, ['run', 'lint'], cwd=devtoolsPath)
+
+def GenTests(api):
+  for mastername, config in MASTERS.iteritems():
+    yield (
+      api.test(config['testname']) +
+      api.properties.generic(
+          buildername=config['buildername'],
+          mastername=mastername,
+      )
+    )