Chromium Code Reviews| OLD | NEW |
|---|---|
| (Empty) | |
| 1 from recipe_engine.types import freeze | |
| 2 | |
| 3 DEPS = [ | |
| 4 'chromium_tests', | |
| 5 'depot_tools/bot_update', | |
| 6 'depot_tools/gclient', | |
| 7 'recipe_engine/path', | |
| 8 'recipe_engine/properties', | |
| 9 'recipe_engine/python', | |
| 10 'recipe_engine/step', | |
| 11 ] | |
| 12 | |
| 13 MASTERS = freeze({ | |
| 14 'chromium.fyi': { | |
| 15 'buildername': 'Devtools', | |
| 16 'testname': 'devtools_fyi', | |
| 17 }, | |
| 18 }) | |
| 19 | |
| 20 def RunSteps(api): | |
| 21 api.gclient.set_config('chromium') | |
| 22 api.bot_update.ensure_checkout(force=True) | |
| 23 | |
| 24 has_devtools_file = False | |
| 25 files = api.chromium_tests.get_files_affected_by_patch() | |
|
chenwilliam
2016/08/30 01:27:55
What I'm trying to do is figure out if the most re
Ryan Tseng
2016/08/30 18:13:39
I'm not super familiar with this but it looks righ
| |
| 26 for f in files: | |
| 27 if f.startswith('third_party/WebKit/Source/devtools'): | |
| 28 has_devtools_file = True | |
| 29 | |
| 30 if not has_devtools_file: | |
| 31 api.step('skip checks', ['echo', 'no devtools file in patch']) | |
| 32 return | |
| 33 | |
| 34 devtoolsPath = api.path['checkout'].join('third_party', 'WebKit', 'Source', | |
|
Ryan Tseng
2016/08/30 18:13:39
Did you get any python coverage errors here? I don
chenwilliam
2016/09/01 18:00:44
Added coverage.
| |
| 35 'devtools') | |
| 36 npmPath = api.path['checkout'].join('third_party', 'WebKit', 'Source', 'devtoo ls', | |
|
Ryan Tseng
2016/08/30 18:13:39
80 char
chenwilliam
2016/09/01 18:00:44
Done.
| |
| 37 'scripts', 'nodejs', 'npm.py') | |
|
Ryan Tseng
2016/08/30 18:13:39
where's this from? I can't find it
chenwilliam
2016/09/01 18:00:44
Just landed in https://codereview.chromium.org/227
| |
| 38 | |
| 39 api.python('install node.js and npm', npmPath, ['--version']) | |
| 40 api.python('install eslint', npmPath, ['install', 'eslint@2']) | |
| 41 api.python('run eslint', npmPath, ['run', 'lint'], cwd=devtoolsPath) | |
| 42 | |
| 43 def GenTests(api): | |
| 44 for mastername, config in MASTERS.iteritems(): | |
| 45 yield ( | |
| 46 api.test(config['testname']) + | |
| 47 api.properties.generic( | |
| 48 buildername=config['buildername'], | |
| 49 mastername=mastername, | |
| 50 ) | |
| 51 ) | |
| OLD | NEW |