Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2290863002: More better const-ness in CFX_CountRef<> (Closed)

Created:
4 years, 3 months ago by Tom Sepez
Modified:
4 years, 3 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

More better const-ness in CFX_CountRef<> There are a couple of places where code is calling GetObject() that should be calling GetPrivateCopy(), but works because the value may not be shared at the time. This just makes it safer. Committed: https://pdfium.googlesource.com/pdfium/+/94fb74c3137ab4f9f817f4cfb14e0a68a677422b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M core/fpdfapi/fpdf_page/cpdf_textobject.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_textstate.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_page/include/cpdf_path.h View 1 chunk +2 lines, -2 lines 0 comments Download
M core/fxcrt/include/cfx_count_ref.h View 1 chunk +0 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (7 generated)
Tom Sepez
Dan, for review.
4 years, 3 months ago (2016-08-29 22:04:49 UTC) #4
dsinclair
lgtm
4 years, 3 months ago (2016-08-30 13:37:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2290863002/1
4 years, 3 months ago (2016-08-30 13:37:39 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 13:37:59 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/94fb74c3137ab4f9f817f4cfb14e0a68a677...

Powered by Google App Engine
This is Rietveld 408576698