chrome/browser/resources/settings/internet_page/internet_detail_page.js - Issue 2290853002: MD Settings: Use network name for detail page title

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/internet_page/internet_detail_page.js

Issue 2290853002: MD Settings: Use network name for detail page title (Closed)

Patch Set: Rebase + use ordered array of types instead of sort Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/internet_page/internet_detail_page.html ('k') | chrome/browser/resources/settings/internet_page/network_summary.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/internet_page/internet_detail_page.js

diff --git a/chrome/browser/resources/settings/internet_page/internet_detail_page.js b/chrome/browser/resources/settings/internet_page/internet_detail_page.js

index 0c6377bda636fcc04252fcf9b59c3c8afca9a82f..f9fc5b0601e001e05ba5b1c7c5b1246c5a1ab049 100644

--- a/chrome/browser/resources/settings/internet_page/internet_detail_page.js

+++ b/chrome/browser/resources/settings/internet_page/internet_detail_page.js

@@ -156,6 +156,10 @@ Polymer({

var ipv4 =

CrOnc.getIPConfigForType(this.networkProperties, CrOnc.IPType.IPV4);

this.IPAddress = (ipv4 && ipv4.IPAddress) || '';

+ // Update the detail page title.

+ this.parentNode.pageTitle =

+ CrOnc.getNetworkName(this.networkProperties, this.i18n);

/** @private */

@@ -238,15 +242,6 @@ Polymer({

/**

- * @return {string} The text to display for the network name.

- * @private

- */

- getStateName_: function() {

- return /** @type {string} */ (

- CrOnc.getActiveValue(this.networkProperties.Name) || '');

- },

- /**

* @return {string} The text to display for the network connection state.

* @private