Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4327)

Unified Diff: chrome/browser/resources/settings/internet_page/internet_detail_page.html

Issue 2290853002: MD Settings: Use network name for detail page title (Closed)
Patch Set: Rebase + use ordered array of types instead of sort Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/settings/internet_page/internet_detail_page.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/internet_page/internet_detail_page.html
diff --git a/chrome/browser/resources/settings/internet_page/internet_detail_page.html b/chrome/browser/resources/settings/internet_page/internet_detail_page.html
index 924771d3163432f16272830dc7d80fbe939e68d7..98c86023481921123ba542a7c5c410d14f5c6f05 100644
--- a/chrome/browser/resources/settings/internet_page/internet_detail_page.html
+++ b/chrome/browser/resources/settings/internet_page/internet_detail_page.html
@@ -28,8 +28,9 @@
}
cr-network-icon {
- -webkit-margin-end: 20px;
+ -webkit-margin-end: 15px;
height: 32px;
+ margin-top: -4px; /* Align better with text */
width: 32px;
}
@@ -51,16 +52,12 @@
margin: 10px 0;
}
- #networkName {
- /* TODO(stevenjb): Finalize font-size for this and networkState. */
+ #networkState {
+ /* TODO(stevenjb): Finalize font-size / style for this. */
font-size: 125%;
font-weight: 500;
}
- #networkState {
- @apply(--settings-secondary);
- }
-
#networkState[connected] {
color: var(--google-green-500);
}
@@ -75,12 +72,9 @@
<div class="start layout horizontal center">
<cr-network-icon network-state="[[networkProperties]]">
</cr-network-icon>
- <div class="layout vertical">
- <div id="networkName">[[getStateName_(networkProperties)]]</div>
- <div id="networkState"
- connected$="[[isConnectedState_(networkProperties)]]">
- [[getStateText_(networkProperties)]]
- </div>
+ <div id="networkState"
+ connected$="[[isConnectedState_(networkProperties)]]">
+ [[getStateText_(networkProperties)]]
</div>
</div>
<div id="buttonDiv" class="layout horizontal center">
« no previous file with comments | « no previous file | chrome/browser/resources/settings/internet_page/internet_detail_page.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698