Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Issue 2290753004: Finish changing chrome/ grit includes to use qualified paths. (Closed)

Created:
4 years, 3 months ago by Lei Zhang
Modified:
4 years, 3 months ago
CC:
achuith+watch_chromium.org, alemate+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, davemoore+watch_chromium.org, dbeam+watch-settings_chromium.org, dbeam+watch-options_chromium.org, eroman, extensions-reviews_chromium.org, gcasto+watchlist_chromium.org, kalyank, kinuko+fileapi, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-options_chromium.org, mmenke, nhiroki, oshima+watch_chromium.org, sadrul, stevenjb+watch-md-settings_chromium.org, tfarina, tzik, vabr+watchlistpasswordmanager_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Finish changing chrome/ grit includes to use qualified paths. BUG=401588 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/ab06827e6a7d2df04152aec708da1069317913d9 Cr-Commit-Position: refs/heads/master@{#415379}

Patch Set 1 #

Patch Set 2 : DEPS #

Patch Set 3 : mac #

Patch Set 4 : Add use_qualified_include #

Patch Set 5 : Punt on a few use_qualified_include for now #

Patch Set 6 : Add missing file #

Patch Set 7 : Rebase, fix new unqualified include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -64 lines) Patch
M chrome/app/BUILD.gn View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/app/DEPS View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/app/resources/BUILD.gn View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
A + chrome/app/resources/DEPS View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/theme/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/DEPS View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/hats/hats_notification_controller.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/quick_unlock/quick_unlock_notification_controller.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/resource_loader_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/status/data_promo_notification.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/DEPS View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/chrome_component_extension_resource_manager.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/component_extensions_whitelist/whitelist.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/component_loader.cc View 2 chunks +7 lines, -10 lines 0 comments Download
M chrome/browser/extensions/extension_action.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/BUILD.gn View 1 2 3 4 11 chunks +14 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/strings/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/chrome_screenshot_grabber.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/extension_launcher_context_menu.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_context_menu.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.mm View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/chooser_content_view_cocoa.mm View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/translate/translate_bubble_controller.mm View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/DEPS View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/chooser_content_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/desktop_capture/desktop_media_list_view.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/about_ui.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/gcm_internals_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/invalidations_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/net_internals/net_internals_ui.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/chromeos/display_options_handler.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/chromeos/user_image_source.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/webui/options/options_ui.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/password_manager_internals/password_manager_internals_ui.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/quota_internals/quota_internals_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_ui.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/signin/md_user_manager_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/sync_file_system_internals/sync_file_system_internals_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/sync_internals_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/translate_internals/translate_internals_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/web_applications/web_app_mac.mm View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/common/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/DEPS View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/DEPS View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/BUILD.gn View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 25 (16 generated)
Lei Zhang
4 years, 3 months ago (2016-08-30 08:45:26 UTC) #5
jochen (gone - plz use gerrit)
lgtm
4 years, 3 months ago (2016-08-30 11:46:44 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2290753004/120001
4 years, 3 months ago (2016-08-30 16:34:02 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/249290)
4 years, 3 months ago (2016-08-30 16:41:54 UTC) #16
Lei Zhang
4 years, 3 months ago (2016-08-30 17:11:57 UTC) #18
Dan Beam
lgtm
4 years, 3 months ago (2016-08-30 18:50:41 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2290753004/120001
4 years, 3 months ago (2016-08-30 18:52:04 UTC) #21
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 3 months ago (2016-08-30 18:59:14 UTC) #23
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 19:01:39 UTC) #25
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/ab06827e6a7d2df04152aec708da1069317913d9
Cr-Commit-Position: refs/heads/master@{#415379}

Powered by Google App Engine
This is Rietveld 408576698