Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 2290653003: Convince gcc that local variables in i::ValueDeserializer::ReadJSArrayBufferView are initialized. (Closed)

Created:
4 years, 3 months ago by jbroman
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Convince gcc that local variables in i::ValueDeserializer::ReadJSArrayBufferView are initialized. It emits spurious -Wmaybe-uninitialized warnings. Initializing these variables shouldn't do any harm (with an optimizing compiler), so this seems the quickest way to mollify gcc. BUG=chromium:148757 Committed: https://crrev.com/88d603bb550827b179a7f6cf67e9c16a6b2d5f60 Cr-Commit-Position: refs/heads/master@{#39000}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/value-serializer.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (7 generated)
jbroman
I can't reproduce the original error locally, even with is_clang=false, but it seems clear that ...
4 years, 3 months ago (2016-08-29 21:12:28 UTC) #4
jbroman
(In response to https://codereview.chromium.org/2287653002/#msg21)
4 years, 3 months ago (2016-08-29 21:12:46 UTC) #5
Jakob Kummerow
lgtm
4 years, 3 months ago (2016-08-30 08:29:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2290653003/1
4 years, 3 months ago (2016-08-30 08:30:10 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 09:41:29 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 09:41:53 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/88d603bb550827b179a7f6cf67e9c16a6b2d5f60
Cr-Commit-Position: refs/heads/master@{#39000}

Powered by Google App Engine
This is Rietveld 408576698