Throw exceptions for errors in v8::ValueSerializer.

Throw exceptions for errors in v8::ValueSerializer.

BUG=chromium:148757, chromium:641964
Committed: https://crrev.com/f72351f5400151d9a4b63da2be4049f4c8155e75
Cr-Commit-Position: refs/heads/master@{#39140}

[jbroman, 2016-09-01 17:08:50]

The CQ bit was checked by jbroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 17:09:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 17:11:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 17:11:32]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)

[jbroman, 2016-09-01 17:15:13]

The CQ bit was checked by jbroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 17:15:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 17:43:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 17:43:31]

Dry run: This issue passed the CQ dry run.

[jbroman, 2016-09-01 17:55:46]

jbroman@chromium.org changed reviewers:
+ jkummerow@chromium.org

[jbroman, 2016-09-01 17:55:47]

This provides a facility whereby Blink can throw DOMException (with a
suitably-formatted message which includes the name of the method that caused the
call) even though V8 doesn't know what DOMException is.

I intend to deal with v8::ValueDeserializer in a followup CL. What it does is
less important, as in practice Blink wants to return "null" rather than throw
during deserialization.

[Jakob Kummerow, 2016-09-02 10:20:28]

LGTM.

https://codereview.chromium.org/2307603002/diff/20001/src/value-serializer.cc
File src/value-serializer.cc (right):

https://codereview.chromium.org/2307603002/diff/20001/src/value-serializer.cc...
src/value-serializer.cc:253:
ThrowDataCloneError(MessageTemplate::kDataCloneError, object);
I'm not sure about this case. UNIMPLEMENTED() crashes even in Release mode. If
hitting this case can happen during normal operation and must be handled by
embedders, then throwing an error is of course appropriate. On the other hand,
if you'd say that hitting this case would be a V8/Chrome bug and we should learn
about it in the form of a crash report, then you should keep the
UNIMPLEMENTED().

https://codereview.chromium.org/2307603002/diff/20001/src/value-serializer.cc...
src/value-serializer.cc:375:
ThrowDataCloneError(MessageTemplate::kDataCloneError, receiver);
same here

https://codereview.chromium.org/2307603002/diff/20001/src/value-serializer.h
File src/value-serializer.h (right):

https://codereview.chromium.org/2307603002/diff/20001/src/value-serializer.h#...
src/value-serializer.h:110: * Asks the delegate to throw handle an error that
occurred during data
nit: s/throw handle/handle/

[jbroman, 2016-09-02 14:51:03]

The CQ bit was checked by jbroman@chromium.org

[jbroman, 2016-09-02 14:51:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
jkummerow@chromium.org
Link to the patchset: https://codereview.chromium.org/2307603002/#ps40001
(title: "fix comment")

[commit-bot: I haz the power, 2016-09-02 14:51:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbroman, 2016-09-02 14:51:09]

https://codereview.chromium.org/2307603002/diff/20001/src/value-serializer.cc
File src/value-serializer.cc (right):

https://codereview.chromium.org/2307603002/diff/20001/src/value-serializer.cc...
src/value-serializer.cc:253:
ThrowDataCloneError(MessageTemplate::kDataCloneError, object);
On 2016/09/02 at 10:20:28, Jakob wrote:
> I'm not sure about this case. UNIMPLEMENTED() crashes even in Release mode. If
hitting this case can happen during normal operation and must be handled by
embedders, then throwing an error is of course appropriate. On the other hand,
if you'd say that hitting this case would be a V8/Chrome bug and we should learn
about it in the form of a crash report, then you should keep the
UNIMPLEMENTED().

At the moment, this is the case that handles Symbol, SIMD, and other objects,
which a caller might pass to postMessage. While it might be possible to
eventually enumerate all of those, I think it's reasonable to just throw an
error here.

https://codereview.chromium.org/2307603002/diff/20001/src/value-serializer.cc...
src/value-serializer.cc:375:
ThrowDataCloneError(MessageTemplate::kDataCloneError, receiver);
On 2016/09/02 at 10:20:28, Jakob wrote:
> same here

Similarly, there are a number of kinds of receiver that should throw an error
when you try to clone them, like Promise, WeakMap, the various collection
iterators, etc. Because these values come from JavaScript, it's not a bug in
Chrome if someone attempts to clone one of them.

https://codereview.chromium.org/2307603002/diff/20001/src/value-serializer.h
File src/value-serializer.h (right):

https://codereview.chromium.org/2307603002/diff/20001/src/value-serializer.h#...
src/value-serializer.h:110: * Asks the delegate to throw handle an error that
occurred during data
On 2016/09/02 at 10:20:28, Jakob wrote:
> nit: s/throw handle/handle/

Done.

[commit-bot: I haz the power, 2016-09-02 15:16:31]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-02 15:17:14]

Description was changed from

==========
Throw exceptions for errors in v8::ValueSerializer.

BUG=chromium:148757,chromium:641964
==========

to

==========
Throw exceptions for errors in v8::ValueSerializer.

BUG=chromium:148757,chromium:641964

Committed: https://crrev.com/f72351f5400151d9a4b63da2be4049f4c8155e75
Cr-Commit-Position: refs/heads/master@{#39140}
==========

[commit-bot: I haz the power, 2016-09-02 15:17:16]

Patchset 3 (id:??) landed as
https://crrev.com/f72351f5400151d9a4b63da2be4049f4c8155e75
Cr-Commit-Position: refs/heads/master@{#39140}