Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2290653002: change readTypeface to return sk_sp (Closed)

Created:
4 years, 3 months ago by reed1
Modified:
4 years, 3 months ago
Reviewers:
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

change readTypeface to return sk_sp BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2290653002 TBR=mtklein Committed: https://skia.googlesource.com/skia/+/2867e7648069272ad1827ebafe49bd0d22a619b3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -19 lines) Patch
M src/core/SkPaint.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkReadBuffer.h View 1 chunk +1 line, -6 lines 0 comments Download
M src/core/SkReadBuffer.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M src/core/SkValidatingReadBuffer.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/core/SkValidatingReadBuffer.cpp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2290653002/1
4 years, 3 months ago (2016-08-29 13:38:23 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-08-29 13:57:31 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/2867e7648069272ad1827ebafe49bd0d22a619b3

Powered by Google App Engine
This is Rietveld 408576698