Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: src/core/SkReadBuffer.h

Issue 2290653002: change readTypeface to return sk_sp (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/core/SkPaint.cpp ('k') | src/core/SkReadBuffer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/core/SkReadBuffer.h
diff --git a/src/core/SkReadBuffer.h b/src/core/SkReadBuffer.h
index a8bed7be48e71654365d5f9e8586ecdc68ac6d45..7c4ecc6bd371293353ad4f05c6ca47556bce64e6 100644
--- a/src/core/SkReadBuffer.h
+++ b/src/core/SkReadBuffer.h
@@ -166,14 +166,9 @@ public:
// helpers to get info about arrays and binary data
virtual uint32_t getArrayCount();
- /**
- * Returns false if the image could not be completely read. In that case, it will be set
- * to have width/height, but no pixels.
- */
sk_sp<SkImage> readBitmapAsImage();
sk_sp<SkImage> readImage();
-
- virtual SkTypeface* readTypeface();
+ virtual sk_sp<SkTypeface> readTypeface();
void setTypefaceArray(SkTypeface* array[], int count) {
fTFArray = array;
« no previous file with comments | « src/core/SkPaint.cpp ('k') | src/core/SkReadBuffer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698