Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2290603004: Merged: PPC/s390: Fix register mapping and imm16 issue (Closed)

Created:
4 years, 3 months ago by JaideepBajwa
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com, v8-merges_googlegroups.com, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@5.4
Target Ref:
refs/pending/branch-heads/5.4
Project:
v8
Visibility:
Public.

Description

Merged: PPC/s390: Fix register mapping and imm16 issue Revision: f3bf8f92a50df703cbe5ab8663ca6dc9726a2c73 R=hablich@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= NOTRY=true NOPRESUBMIT=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -17 lines) Patch
M include/v8-version.h View 1 chunk +1 line, -1 line 0 comments Download
M src/builtins/ppc/builtins-ppc.cc View 3 chunks +8 lines, -7 lines 0 comments Download
M src/builtins/s390/builtins-s390.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
JaideepBajwa
PTAL
4 years, 3 months ago (2016-08-29 15:25:13 UTC) #2
Michael Hablich
On 2016/08/29 15:25:13, JaideepBajwa wrote: > PTAL lgtm, you should update your repo btw, there ...
4 years, 3 months ago (2016-08-30 07:00:07 UTC) #3
JaideepBajwa
On 2016/08/30 07:00:07, Hablich wrote: > On 2016/08/29 15:25:13, JaideepBajwa wrote: > > PTAL > ...
4 years, 3 months ago (2016-08-30 13:13:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2290603004/1
4 years, 3 months ago (2016-08-30 13:13:31 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 13:13:50 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698