Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 2290523005: Simplify AnimationTestHelper.h (Closed)

Created:
4 years, 3 months ago by esprehn
Modified:
4 years, 3 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify AnimationTestHelper.h We don't need these extra helper functions and we can use StringView to avoid allocating temporary strings. BUG=615174 Committed: https://crrev.com/572944fef3414bbbc946e732afca05e80813ba95 Cr-Commit-Position: refs/heads/master@{#415064}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -21 lines) Patch
M third_party/WebKit/Source/core/animation/AnimationTestHelper.h View 1 chunk +3 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/animation/AnimationTestHelper.cpp View 1 chunk +4 lines, -14 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
esprehn
4 years, 3 months ago (2016-08-29 22:26:27 UTC) #4
haraken
LGTM
4 years, 3 months ago (2016-08-29 22:27:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2290523005/1
4 years, 3 months ago (2016-08-30 02:11:07 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 03:57:21 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/572944fef3414bbbc946e732afca05e80813ba95 Cr-Commit-Position: refs/heads/master@{#415064}
4 years, 3 months ago (2016-08-30 03:59:57 UTC) #14
suzyh_UTC10 (ex-contributor)
4 years, 3 months ago (2016-08-30 04:00:56 UTC) #15
Message was sent while issue was closed.
Looks like I'm just too late to the party. But FWIW, lgtm, although I did wonder
whether the wtf/text/WTFString.h include in the header was still necessary.

Powered by Google App Engine
This is Rietveld 408576698