Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Side by Side Diff: third_party/WebKit/Source/core/animation/AnimationTestHelper.cpp

Issue 2290523005: Simplify AnimationTestHelper.h (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/animation/AnimationTestHelper.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/animation/AnimationTestHelper.h" 5 #include "core/animation/AnimationTestHelper.h"
6 6
7 #include "bindings/core/v8/V8Binding.h" 7 #include "bindings/core/v8/V8Binding.h"
8 8
9 namespace blink { 9 namespace blink {
10 10
11 v8::Local<v8::Value> stringToV8Value(String string) 11 void setV8ObjectPropertyAsString(v8::Isolate* isolate, v8::Local<v8::Object> obj ect, const StringView& name, const StringView& value)
12 { 12 {
13 return v8::Local<v8::Value>::Cast(v8String(v8::Isolate::GetCurrent(), string )); 13 object->Set(isolate->GetCurrentContext(), v8String(isolate, name), v8String( isolate, value)).ToChecked();
14 } 14 }
15 15
16 v8::Local<v8::Value> doubleToV8Value(double number) 16 void setV8ObjectPropertyAsNumber(v8::Isolate* isolate, v8::Local<v8::Object> obj ect, const StringView& name, double value)
17 { 17 {
18 return v8::Local<v8::Value>::Cast(v8::Number::New(v8::Isolate::GetCurrent(), number)); 18 object->Set(isolate->GetCurrentContext(), v8String(isolate, name), v8::Numbe r::New(isolate, value)).ToChecked();
19 }
20
21 void setV8ObjectPropertyAsString(v8::Isolate* isolate, v8::Local<v8::Object> obj ect, String name, String value)
22 {
23 object->Set(isolate->GetCurrentContext(), stringToV8Value(name), stringToV8V alue(value)).ToChecked();
24 }
25
26 void setV8ObjectPropertyAsNumber(v8::Isolate* isolate, v8::Local<v8::Object> obj ect, String name, double value)
27 {
28 object->Set(isolate->GetCurrentContext(), stringToV8Value(name), doubleToV8V alue(value)).ToChecked();
29 } 19 }
30 20
31 } // namespace blink 21 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/animation/AnimationTestHelper.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698