Chromium Code Reviews Chromium Code Reviews
Issue 229043004:
Fixed crash in WebFrameImpl::resetMatchCount function. (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master| Index: Source/web/tests/data/find_in_generated_frame.html |
| diff --git a/Source/web/tests/data/find_in_generated_frame.html b/Source/web/tests/data/find_in_generated_frame.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..5f028cb7e2993b5168b5b8929cd55c04744af05e |
| --- /dev/null |
| +++ b/Source/web/tests/data/find_in_generated_frame.html |
| @@ -0,0 +1,40 @@ |
| +<!DOCTYPE html> |
| +<html> |
| +<head> |
| +<script> |
| +onload = function() { |
| + // See http://code.google.com/p/chromium/issues/detail?id=359983 for details. |
| + var tasks = [ |
| + function () { |
|
yosin_UTC9
2014/05/29 01:33:27
You can move svgElem1, svgElem2, titleElem initial
|
| + svgElem1 = document.createElementNS('http://www.w3.org/2000/svg', 'svg'); |
| + }, |
| + function () { |
| + svgElem2 = document.createElementNS('http://www.w3.org/2000/svg', 'svg'); |
|
yosin_UTC9
2014/05/29 01:33:27
nit: we can remove this. |svgElem2| never used.
|
| + }, |
| + function () { |
| + titleElem = document.createElementNS('http://www.w3.org/2000/svg', 'title'); |
|
yosin_UTC9
2014/05/29 01:33:27
nit: we can remove this. |titleElem|. never used.
|
| + }, |
| + function () { |
| + generatedFrame = document.createElement('iframe'); |
| + if (!svgElem1.parentNode) { |
|
yosin_UTC9
2014/05/29 01:33:27
nit: svgElem1.parentNode is null here. Because it
|
| + document.body.appendChild(svgElem1); |
| + } |
| + svgElem1.parentNode.insertBefore(generatedFrame, svgElem1); |
|
yosin_UTC9
2014/05/29 01:33:27
It seems you can build |generatedFrame| by using "
|
| + } |
| + ]; |
| + |
| + function runTasks() { |
| + while (tasks.length > 0) { |
| + var task = tasks.shift(); |
| + task(); |
| + } |
| + } |
| + |
| + setTimeout(runTasks, 0); |
|
yosin_UTC9
2014/05/29 01:33:27
nit: window.onload = runTasks;
I think this can r
|
| +} |
| +</script> |
| +</head> |
| +<body> |
| +test |
| +</body> |
| +</html> |
