Source/web/tests/data/find_in_generated_frame.html - Issue 229043004: Fixed crash in WebFrameImpl::resetMatchCount function.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/web/tests/data/find_in_generated_frame.html

Issue 229043004: Fixed crash in WebFrameImpl::resetMatchCount function. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Added delay Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <script>

	5 onload = function() {

	6 // See http://code.google.com/p/chromium/issues/detail?id=359983 for details.

	7 var tasks = [

	8 function () {
	yosin_UTC9 2014/05/29 01:33:27 You can move svgElem1, svgElem2, titleElem initial You can move svgElem1, svgElem2, titleElem initialization into the last function.
	9 svgElem1 = document.createElementNS('http://www.w3.org/2000/svg', 'svg');

	10 },

	11 function () {

	12 svgElem2 = document.createElementNS('http://www.w3.org/2000/svg', 'svg');
	yosin_UTC9 2014/05/29 01:33:27 nit: we can remove this. \|svgElem2\| never used. nit: we can remove this. \|svgElem2\| never used.
	13 },

	14 function () {

	15 titleElem = document.createElementNS('http://www.w3.org/2000/svg', 'title' );
	yosin_UTC9 2014/05/29 01:33:27 nit: we can remove this. \|titleElem\|. never used. nit: we can remove this. \|titleElem\|. never used.
	16 },

	17 function () {

	18 generatedFrame = document.createElement('iframe');

	19 if (!svgElem1.parentNode) {
	yosin_UTC9 2014/05/29 01:33:27 nit: svgElem1.parentNode is null here. Because it nit: svgElem1.parentNode is null here. Because it is created in L9.
	20 document.body.appendChild(svgElem1);

	21 }

	22 svgElem1.parentNode.insertBefore(generatedFrame, svgElem1);
	yosin_UTC9 2014/05/29 01:33:27 It seems you can build \|generatedFrame\| by using " It seems you can build \|generatedFrame\| by using "srcdoc" attribute, e.g. data:text/html,<iframe srcdoc="<b>Foo</b>" width="200" height="300"></frame> I guess we don't need to use SVG element.
	23 }

	24 ];

	25

	26 function runTasks() {

	27 while (tasks.length > 0) {

	28 var task = tasks.shift();

	29 task();

	30 }

	31 }

	32

	33 setTimeout(runTasks, 0);
	yosin_UTC9 2014/05/29 01:33:27 nit: window.onload = runTasks; I think this can r nit: window.onload = runTasks; I think this can resolve timing issue. timeout can be fired before BODY element rendered; parser has one shot timer to start rendering slow channel. BOT is always slow.
	34 }

	35 </script>

	36 </head>

	37 <body>

	38 test

	39 </body>

	40 </html>

OLD	NEW

« no previous file with comments | « Source/web/tests/WebFrameTest.cpp ('k') | no next file » | no next file with comments »