Make android lint suppressions file overridable.

Make android lint suppressions file overridable.

This makes possible for other projects to use their own lint suppressions file.
WebRTC for example, uses its own lint suppressions file.

BUG=

Committed: https://crrev.com/72d0476e489b44c7e1e395524a9804d386ad290e
Cr-Commit-Position: refs/heads/master@{#415304}

[ehmaldonado_chromium, 2016-08-30 14:20:41]

Patchset #1 (id:1) has been deleted

[ehmaldonado_chromium, 2016-08-30 14:32:11]

Description was changed from

==========
Make android lint suppressions file overridable.

BUG=
==========

to

==========
Make android lint suppressions file overridable.

This makes possible for other projects to use their own lint suppressions file.
WebRTC for example, uses its own lint suppressions file.

BUG=
==========

[ehmaldonado_chromium, 2016-08-30 14:32:44]

ehmaldonado@chromium.org changed reviewers:
+ agrieve@chromium.org, kjellander@chromium.org

[agrieve, 2016-08-30 14:36:37]

lgtm /w nit

https://codereview.chromium.org/2290323002/diff/20001/build/config/android/in...
File build/config/android/internal_rules.gni (right):

https://codereview.chromium.org/2290323002/diff/20001/build/config/android/in...
build/config/android/internal_rules.gni:654: lint_suppressions_file =
"//build/android/lint/suppressions.xml"
nit: Can you either set this default value in //build_overrides/build.gni, or
add a comment there about this being an overridable value?

[ehmaldonado_chromium, 2016-08-30 14:44:59]

On 2016/08/30 14:36:37, agrieve wrote:
> lgtm /w nit
> 
>
https://codereview.chromium.org/2290323002/diff/20001/build/config/android/in...
> File build/config/android/internal_rules.gni (right):
> 
>
https://codereview.chromium.org/2290323002/diff/20001/build/config/android/in...
> build/config/android/internal_rules.gni:654: lint_suppressions_file =
> "//build/android/lint/suppressions.xml"
> nit: Can you either set this default value in //build_overrides/build.gni, or
> add a comment there about this being an overridable value?

Added comment in //build_overrides/build.gni

[ehmaldonado_chromium, 2016-08-30 14:48:08]

The CQ bit was checked by ehmaldonado@chromium.org

[ehmaldonado_chromium, 2016-08-30 14:48:09]

The patchset sent to the CQ was uploaded after l-g-t-m from agrieve@chromium.org
Link to the patchset: https://codereview.chromium.org/2290323002/#ps40001
(title: "Add comment in build_overrides/build.gni")

[commit-bot: I haz the power, 2016-08-30 14:48:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 15:53:56]

Description was changed from

==========
Make android lint suppressions file overridable.

This makes possible for other projects to use their own lint suppressions file.
WebRTC for example, uses its own lint suppressions file.

BUG=
==========

to

==========
Make android lint suppressions file overridable.

This makes possible for other projects to use their own lint suppressions file.
WebRTC for example, uses its own lint suppressions file.

BUG=
==========

[commit-bot: I haz the power, 2016-08-30 15:53:57]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-08-30 15:55:28]

Description was changed from

==========
Make android lint suppressions file overridable.

This makes possible for other projects to use their own lint suppressions file.
WebRTC for example, uses its own lint suppressions file.

BUG=
==========

to

==========
Make android lint suppressions file overridable.

This makes possible for other projects to use their own lint suppressions file.
WebRTC for example, uses its own lint suppressions file.

BUG=

Committed: https://crrev.com/72d0476e489b44c7e1e395524a9804d386ad290e
Cr-Commit-Position: refs/heads/master@{#415304}
==========

[commit-bot: I haz the power, 2016-08-30 15:55:29]

Patchset 2 (id:??) landed as
https://crrev.com/72d0476e489b44c7e1e395524a9804d386ad290e
Cr-Commit-Position: refs/heads/master@{#415304}