Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Side by Side Diff: build/config/android/internal_rules.gni

Issue 2290323002: Make android lint suppressions file overridable. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build_overrides/build.gni")
5 import("//build/config/android/config.gni") 6 import("//build/config/android/config.gni")
6 import("//build/config/sanitizers/sanitizers.gni") 7 import("//build/config/sanitizers/sanitizers.gni")
7 8
8 assert(is_android) 9 assert(is_android)
9 10
10 # These identify targets that have .build_config files (except for android_apk, 11 # These identify targets that have .build_config files (except for android_apk,
11 # java_binary, resource_rewriter, since we never need to depend on these). 12 # java_binary, resource_rewriter, since we never need to depend on these).
12 _java_target_whitelist = [ 13 _java_target_whitelist = [
13 "*:*_java", 14 "*:*_java",
14 "*:*_javalib", 15 "*:*_javalib",
(...skipping 626 matching lines...) Expand 10 before | Expand all | Expand 10 after
641 forward_variables_from(invoker, 642 forward_variables_from(invoker,
642 [ 643 [
643 "deps", 644 "deps",
644 "data_deps", 645 "data_deps",
645 "public_deps", 646 "public_deps",
646 "testonly", 647 "testonly",
647 ]) 648 ])
648 if (!defined(deps)) { 649 if (!defined(deps)) {
649 deps = [] 650 deps = []
650 } 651 }
652
653 if (!defined(lint_suppressions_file)) {
654 lint_suppressions_file = "//build/android/lint/suppressions.xml"
agrieve 2016/08/30 14:36:37 nit: Can you either set this default value in //bu
655 }
656
651 _cache_dir = "$root_build_dir/android_lint_cache" 657 _cache_dir = "$root_build_dir/android_lint_cache"
652 _result_path = "$target_gen_dir/$target_name/result.xml" 658 _result_path = "$target_gen_dir/$target_name/result.xml"
653 _config_path = "$target_gen_dir/$target_name/config.xml" 659 _config_path = "$target_gen_dir/$target_name/config.xml"
654 _suppressions_file = "//build/android/lint/suppressions.xml" 660 _suppressions_file = lint_suppressions_file
655 _platform_xml_path = 661 _platform_xml_path =
656 "${android_sdk_root}/platform-tools/api/api-versions.xml" 662 "${android_sdk_root}/platform-tools/api/api-versions.xml"
657 _rebased_lint_android_sdk_root = 663 _rebased_lint_android_sdk_root =
658 rebase_path(lint_android_sdk_root, root_build_dir) 664 rebase_path(lint_android_sdk_root, root_build_dir)
659 665
660 script = "//build/android/gyp/lint.py" 666 script = "//build/android/gyp/lint.py"
661 depfile = "$target_gen_dir/$target_name.d" 667 depfile = "$target_gen_dir/$target_name.d"
662 inputs = [ 668 inputs = [
663 _platform_xml_path, 669 _platform_xml_path,
664 _suppressions_file, 670 _suppressions_file,
(...skipping 1964 matching lines...) Expand 10 before | Expand all | Expand 10 after
2629 outputs = [ 2635 outputs = [
2630 depfile, 2636 depfile,
2631 invoker.out_manifest, 2637 invoker.out_manifest,
2632 ] 2638 ]
2633 inputs = [ 2639 inputs = [
2634 invoker.main_manifest, 2640 invoker.main_manifest,
2635 ] 2641 ]
2636 } 2642 }
2637 } 2643 }
2638 } 2644 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698