Make blink::TimerBase own the WebTaskRunner for timer task

Make blink::TimerBase own the WebTaskRunner for timer task

BUG=624696
Committed: https://crrev.com/120ff6435698a4249c043a43325500bc3fdc11ab
Cr-Commit-Position: refs/heads/master@{#416612}

[tzik, 2016-08-30 13:07:13]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 13:07:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tzik, 2016-08-30 13:12:22]

Description was changed from

==========
Make blink::TimerBase own the WebTaskRunner for timer task

BUG=
==========

to

==========
Make blink::TimerBase own the WebTaskRunner for timer task

BUG=624696
==========

[tzik, 2016-08-30 13:12:22]

tzik@chromium.org changed reviewers:
+ haraken@chromium.org

[tzik, 2016-08-30 13:13:56]

PTAL

[commit-bot: I haz the power, 2016-08-30 14:42:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 14:42:20]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[haraken, 2016-08-30 15:39:31]

LGTM

[tzik, 2016-08-31 07:15:47]

tzik@chromium.org changed reviewers:
+ alexclarke@chromium.org, kouhei@chromium.org

[tzik, 2016-08-31 07:15:47]

FakeWebTaskRunner needs an update to fix ImageQualityControllerTest failure.

alex: PTAL to scheduler part?
kouhei: PTAL to layout part?

[kouhei (in TOK), 2016-08-31 07:18:46]

lgtm

[blink-reviews, 2016-08-31 21:58:13]

+skyostil since I'm OOO

On 31 August 2016 at 08:15, <tzik@chromium.org> wrote:

> FakeWebTaskRunner needs an update to fix ImageQualityControllerTest
> failure.
>
> alex: PTAL to scheduler part?
> kouhei: PTAL to layout part?
>
> https://codereview.chromium.org/2290243002/
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[chromium-reviews, 2016-08-31 21:58:13]

+skyostil since I'm OOO

On 31 August 2016 at 08:15, <tzik@chromium.org> wrote:

> FakeWebTaskRunner needs an update to fix ImageQualityControllerTest
> failure.
>
> alex: PTAL to scheduler part?
> kouhei: PTAL to layout part?
>
> https://codereview.chromium.org/2290243002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Sami, 2016-09-01 12:44:20]

skyostil@chromium.org changed reviewers:
+ skyostil@chromium.org

[Sami, 2016-09-01 12:44:21]

lgtm, this makes the ownership model a lot clearer.

[tzik, 2016-09-01 16:55:21]

The CQ bit was checked by tzik@chromium.org

[tzik, 2016-09-01 16:55:21]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2290243002/#ps20001
(title: "+clone() support on FakeWebTaskRunner")

[commit-bot: I haz the power, 2016-09-01 16:55:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 18:26:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 18:26:46]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tzik, 2016-09-02 05:34:37]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 05:34:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 07:40:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 07:40:50]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tzik, 2016-09-02 07:48:03]

The CQ bit was checked by tzik@chromium.org

[tzik, 2016-09-02 07:48:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, skyostil@chromium.org, kouhei@chromium.org
Link to the patchset: https://codereview.chromium.org/2290243002/#ps40001
(title: "use ThreadSafeRefCounted instead of RefCounted")

[commit-bot: I haz the power, 2016-09-02 07:48:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 10:03:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 10:03:03]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tzik, 2016-09-06 08:13:31]

The CQ bit was checked by tzik@chromium.org

[tzik, 2016-09-06 08:13:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, skyostil@chromium.org, kouhei@chromium.org
Link to the patchset: https://codereview.chromium.org/2290243002/#ps60001
(title: "use adoptRef")

[commit-bot: I haz the power, 2016-09-06 08:13:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 09:58:29]

Description was changed from

==========
Make blink::TimerBase own the WebTaskRunner for timer task

BUG=624696
==========

to

==========
Make blink::TimerBase own the WebTaskRunner for timer task

BUG=624696
==========

[commit-bot: I haz the power, 2016-09-06 09:58:29]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-06 10:00:35]

Description was changed from

==========
Make blink::TimerBase own the WebTaskRunner for timer task

BUG=624696
==========

to

==========
Make blink::TimerBase own the WebTaskRunner for timer task

BUG=624696

Committed: https://crrev.com/120ff6435698a4249c043a43325500bc3fdc11ab
Cr-Commit-Position: refs/heads/master@{#416612}
==========

[commit-bot: I haz the power, 2016-09-06 10:00:36]

Patchset 4 (id:??) landed as
https://crrev.com/120ff6435698a4249c043a43325500bc3fdc11ab
Cr-Commit-Position: refs/heads/master@{#416612}