third_party/WebKit/Source/platform/Timer.cpp - Issue 2290243002: Make blink::TimerBase own the WebTaskRunner for timer task

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/Timer.cpp

Issue 2290243002: Make blink::TimerBase own the WebTaskRunner for timer task (Closed)

Patch Set: use adoptRef Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/Timer.cpp

diff --git a/third_party/WebKit/Source/platform/Timer.cpp b/third_party/WebKit/Source/platform/Timer.cpp

index c2eceac5988c9903d4cda0e42876220f46d905a1..8ed079f3f31502703bc065e987c83d3562cddd48 100644

--- a/third_party/WebKit/Source/platform/Timer.cpp

+++ b/third_party/WebKit/Source/platform/Timer.cpp

@@ -44,7 +44,7 @@ TimerBase::TimerBase(WebTaskRunner* webTaskRunner)

: m_nextFireTime(0)

, m_repeatInterval(0)

, m_cancellableTimerTask(nullptr)

- , m_webTaskRunner(webTaskRunner)

+ , m_webTaskRunner(webTaskRunner->clone())

#if DCHECK_IS_ON()

, m_thread(currentThread())

#endif

@@ -100,7 +100,7 @@ WebTaskRunner* TimerBase::getUnthrottledTaskRunner()

WebTaskRunner* TimerBase::timerTaskRunner() const

{

- return m_webTaskRunner;

+ return m_webTaskRunner.get();

}

void TimerBase::setNextFireTime(double now, double delay)