third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp - Issue 2290233007: Move convertViewportToWindow and convertWindowToViewport from

Unified Diff: third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp

Issue 2290233007: Move convertViewportToWindow and convertWindowToViewport from (Closed)

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp b/third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp

index f51f09a1b0ba8634c795256eb9cf06cbed74e570..d6f3ca25508226c7b2c69a451cdaa112d4caeebb 100644

--- a/third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp

+++ b/third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp

@@ -63,6 +63,7 @@

#include "public/platform/WebURLRequest.h"

#include "public/web/WebDevToolsAgent.h"

#include "public/web/WebFrame.h"

+#include "public/web/WebFrameWidget.h"

#include "public/web/WebSettings.h"

#include "public/web/WebView.h"

#include "public/web/WebWorkerContentSettingsClientProxy.h"

@@ -83,6 +84,7 @@ namespace blink {

WebSharedWorkerImpl::WebSharedWorkerImpl(WebSharedWorkerClient* client)

: m_webView(nullptr)

+ , m_webFrameWidget(nullptr)

, m_mainFrame(nullptr)

, m_askedToTerminate(false)

, m_workerInspectorProxy(WorkerInspectorProxy::create())

@@ -99,6 +101,7 @@ WebSharedWorkerImpl::~WebSharedWorkerImpl()

// Detach the client before closing the view to avoid getting called back.

m_mainFrame->setClient(0);

+ m_webFrameWidget->close();

m_webView->close();

m_mainFrame->close();

if (m_loaderProxy)

@@ -137,6 +140,7 @@ void WebSharedWorkerImpl::initializeLoader()

m_mainFrame = toWebLocalFrameImpl(WebLocalFrame::create(WebTreeScopeType::Document, this));

m_webView->setMainFrame(m_mainFrame.get());

m_mainFrame->setDevToolsAgentClient(this);

+ m_webFrameWidget = WebFrameWidget::create(nullptr, m_webView, m_mainFrame);

dcheng 2016/09/02 08:57:39 Shared workers do layout?

lfg 2016/09/02 17:36:38 Yes, they do.

falken 2016/09/08 05:50:39 Can you explain more? They don't need to be doing

lfg 2016/09/08 21:40:43 Yes, several tests fail. For example, here's a cal

falken 2016/09/09 05:04:28 I see. Yikes! I'll update the shadow page bug to m

// If we were asked to pause worker context on start and wait for debugger then it is the good time to do that.

m_client->workerReadyForInspection();