Move convertViewportToWindow and convertWindowToViewport from

third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 45 matching lines @@
 #include "platform/weborigin/KURL.h"
 #include "platform/weborigin/SecurityOrigin.h"
 #include "public/platform/Platform.h"
 #include "public/platform/WebFileError.h"
 #include "public/platform/WebMessagePortChannel.h"
 #include "public/platform/WebString.h"
 #include "public/platform/WebURL.h"
 #include "public/platform/WebURLRequest.h"
 #include "public/web/WebDevToolsAgent.h"
 #include "public/web/WebFrame.h"
+#include "public/web/WebFrameWidget.h"
 #include "public/web/WebSettings.h"
 #include "public/web/WebView.h"
 #include "public/web/WebWorkerContentSettingsClientProxy.h"
 #include "public/web/modules/serviceworker/WebServiceWorkerNetworkProvider.h"
 #include "web/IndexedDBClientImpl.h"
 #include "web/LocalFileSystemClient.h"
 #include "web/WebDataSourceImpl.h"
 #include "web/WebLocalFrameImpl.h"
 #include "web/WorkerContentSettingsClient.h"
 #include "wtf/Functional.h"
 #include "wtf/PtrUtil.h"
 #include <memory>
 
 namespace blink {
 
 // TODO(toyoshim): Share implementation with WebEmbeddedWorkerImpl as much as
 // possible.
 
 WebSharedWorkerImpl::WebSharedWorkerImpl(WebSharedWorkerClient* client)
     : m_webView(nullptr)
+    , m_webFrameWidget(nullptr)
     , m_mainFrame(nullptr)
     , m_askedToTerminate(false)
     , m_workerInspectorProxy(WorkerInspectorProxy::create())
     , m_client(client)
     , m_pauseWorkerContextOnStart(false)
     , m_isPausedOnStart(false)
     , m_creationAddressSpace(WebAddressSpacePublic)
 {
 }
 
 WebSharedWorkerImpl::~WebSharedWorkerImpl()
 {
     DCHECK(m_webView);
     // Detach the client before closing the view to avoid getting called back.
     m_mainFrame->setClient(0);
 
+    m_webFrameWidget->close();
     m_webView->close();
     m_mainFrame->close();
     if (m_loaderProxy)
         m_loaderProxy->detachProvider(this);
 }
 
 void WebSharedWorkerImpl::terminateWorkerThread()
 {
     if (m_askedToTerminate)
         return;
@@ skipping 18 matching lines @@
     DCHECK(!m_webView);
     m_webView = WebView::create(nullptr, WebPageVisibilityStateVisible);
     // FIXME: http://crbug.com/363843. This needs to find a better way to
     // not create graphics layers.
     m_webView->settings()->setAcceleratedCompositingEnabled(false);
     // FIXME: Settings information should be passed to the Worker process from Browser process when the worker
     // is created (similar to RenderThread::OnCreateNewView).
     m_mainFrame = toWebLocalFrameImpl(WebLocalFrame::create(WebTreeScopeType::Document, this));
     m_webView->setMainFrame(m_mainFrame.get());
     m_mainFrame->setDevToolsAgentClient(this);
+    m_webFrameWidget = WebFrameWidget::create(nullptr, m_webView, m_mainFrame);

[dcheng, 2016/09/02 08:57:39]

Shared workers do layout?

[lfg, 2016/09/02 17:36:38]

Yes, they do.

[falken, 2016/09/08 05:50:39]

Can you explain more? They don't need to be doing layout, but maybe it's
happening as a result of the "shadow page" hack. Does something break if we
don't have this webFrameWidget?

[lfg, 2016/09/08 21:40:43]

Yes, several tests fail. For example, here's a callstack when running
WorkerTest.SingleSharedWorker:

blink::ChromeClientImpl::windowToViewportScalar
blink::Scrollbar::Scrollbar
blink::Scrollbar::create
blink::FrameView::createScrollbar
blink::FrameView::setHasVerticalScrollbar
blink::FrameView::adjustScrollbarExistence
blink::FrameView::updateScrollbars
blink::FrameView::setScrollbarModes
blink::FrameView::setVerticalScrollbarMode
blink::FrameView::layout
blink::Document::implicitClose
blink::FrameLoader::checkCompleted
blink::FrameLoader::finishedParsing
blink::Document::finishedParsing
blink::HTMLConstructionSite::finishedParsing
blink::HTMLTreeBuilder::finished
blink::HTMLDocumentParser::end
blink::HTMLDocumentParser::attemptToRunDeferredScriptsAndEnd
blink::HTMLDocumentParser::prepareToStopParsing
blink::HTMLDocumentParser::attemptToEnd
blink::HTMLDocumentParser::finish
blink::DocumentWriter::end
blink::DocumentLoader::endWriting
blink::DocumentLoader::finishedLoading
blink::DocumentLoader::notifyFinished
blink::Resource::didAddClient
blink::RawResource::didAddClient
blink::Resource::finishPendingClients
blink::Resource::ResourceCallback::runTask

frame->document()->url() is
"file:///.../src/content/test/data/workers/worker_common.js

[falken, 2016/09/09 05:04:28]

I see. Yikes! I'll update the shadow page bug to mention FrameView::layout is
for workers because of it.

 
     // If we were asked to pause worker context on start and wait for debugger then it is the good time to do that.
     m_client->workerReadyForInspection();
     if (m_pauseWorkerContextOnStart) {
         m_isPausedOnStart = true;
         return;
     }
     loadShadowPage();
 }
 
@@ skipping 260 matching lines @@
     if (devtoolsAgent)
         devtoolsAgent->dispatchOnInspectorBackend(sessionId, callId, method, message);
 }
 
 WebSharedWorker* WebSharedWorker::create(WebSharedWorkerClient* client)
 {
     return new WebSharedWorkerImpl(client);
 }
 
 } // namespace blink