Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Unified Diff: content/shell/renderer/layout_test/blink_test_runner.cc

Issue 2290233007: Move convertViewportToWindow and convertWindowToViewport from (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/renderer/layout_test/blink_test_runner.cc
diff --git a/content/shell/renderer/layout_test/blink_test_runner.cc b/content/shell/renderer/layout_test/blink_test_runner.cc
index 81e77ccc4de6e411003cb6704a17887e81f42a2b..5062d6fc2bd0b6728c7d485f04ccd65958929450 100644
--- a/content/shell/renderer/layout_test/blink_test_runner.cc
+++ b/content/shell/renderer/layout_test/blink_test_runner.cc
@@ -494,7 +494,7 @@ void BlinkTestRunner::SetDeviceScaleFactor(float factor) {
}
float BlinkTestRunner::GetWindowToViewportScale() {
- return content::GetWindowToViewportScale(render_view());
+ return content::GetWindowToViewportScale(render_view()->GetMainRenderFrame());
dcheng 2016/09/02 08:57:39 And these would also need to be frame-associated a
lfg 2016/09/02 17:36:37 Yes, I spent a bit of time looking at that, but th
dcheng 2016/09/08 05:25:47 Just to confirm: this will explode horribly at som
lfg 2016/09/08 21:40:43 Yes, if the main_render_frame_ is null this will c
}
void BlinkTestRunner::EnableUseZoomForDSF() {

Powered by Google App Engine
This is Rietveld 408576698