Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorHighlight.cpp

Issue 2290233007: Move convertViewportToWindow and convertWindowToViewport from (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/InspectorHighlight.cpp
diff --git a/third_party/WebKit/Source/core/inspector/InspectorHighlight.cpp b/third_party/WebKit/Source/core/inspector/InspectorHighlight.cpp
index b69bf78748a0bc62f544bc00393323ff0a2b6cdc..7bc953c82232237f2007c826ea63e7ff76d54539 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorHighlight.cpp
+++ b/third_party/WebKit/Source/core/inspector/InspectorHighlight.cpp
@@ -242,7 +242,7 @@ InspectorHighlight::InspectorHighlight(Node* node, const InspectorHighlightConfi
{
FrameView* frameView = node->document().view();
if (frameView)
- m_scale = 1.f / frameView->getHostWindow()->windowToViewportScalar(1.f);
+ m_scale = 1.f / frameView->getHostWindow()->windowToViewportScalar(1.f, frameView);
dcheng 2016/09/08 05:25:47 This might be a dumb question, but why isn't this
lfg 2016/09/08 21:40:43 This is also used in Source/platform/scroll/Scroll
appendPathsForShapeOutside(node, highlightConfig);
appendNodeHighlight(node, highlightConfig);
if (appendElementInfo && node->isElementNode())

Powered by Google App Engine
This is Rietveld 408576698